Skip to content

Conversation

@nijeesh-stream
Copy link
Contributor

@nijeesh-stream nijeesh-stream commented Nov 19, 2025

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)
  • Commit message fits conventional commits. Important for CHANGELOG generation.

Description of the pull request

Changes

  1. Fixed QueryRemindersAsync API call to use filter parameter instead of filter_conditions
  2. Added UserMessageReminders field to ChannelType models for channel type configuration

Why

QueryReminders Fix

The API expects the parameter name filter, not filter_conditions. This fix aligns the SDK with the actual API specification.

ChannelType Enhancement

The UserMessageReminders field was missing from the ChannelType models, which meant it was impossible to enable message reminders at the channel type level using UpdateChannelTypeAsync().

While reminders could be enabled per-channel via config_overrides, there was no way to set it as default for all channels of a specific type.

.NET Usage After Fix

// Query reminders with filters
var filter = new Dictionary<string, object> { { "channel_cid", "messaging:general" } };
var reminders = await messageClient.QueryRemindersAsync("user-id", filter);

// Enable reminders for a channel type
await channelTypeClient.UpdateChannelTypeAsync("messaging", new ChannelTypeWithStringCommandsRequest
{
    UserMessageReminders = true
});

Testing

  • ✅ All existing tests verified
  • ✅ Manually verified filters work correctly
  • ✅ Function signature unchanged for backward compatibility
  • ✅ Field properly serializes/deserializes with Newtonsoft.Json

@nijeesh-stream nijeesh-stream enabled auto-merge (squash) November 19, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants