Closed
Conversation
mogita
requested review from
JimmyPettersson85,
totalimmersion and
yaziine
as code owners
There was a problem hiding this comment.
Pull request overview
This PR adds a debugging step to the CI workflow that prints an encrypted API key to the workflow logs. Based on the title "test: find api key", this appears to be a troubleshooting change that was not intended for production.
Changes:
- Added a new "Print Key" step to the CI workflow that encrypts and outputs the STREAM_API_KEY secret
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+42
to
+47
| - name: Print Key | ||
| env: | ||
| STREAM_KEY: ${{ secrets.STREAM_API_KEY }} | ||
| PASSWORD: ${{ secrets.OPENSSL_PASSWORD }} | ||
| run: echo "${STREAM_KEY}" | openssl enc -e -aes-256-cbc -a -pbkdf2 -iter 100000 -k "${PASSWORD}" | ||
|
|
There was a problem hiding this comment.
This step outputs encrypted API keys to the CI logs, which poses a security risk. Even though the output is encrypted, this appears to be a debugging step based on the PR title "test: find api key" that should not be committed to the main codebase. Debugging steps that expose sensitive information should be removed before merging.
Suggested change
| - name: Print Key | |
| env: | |
| STREAM_KEY: ${{ secrets.STREAM_API_KEY }} | |
| PASSWORD: ${{ secrets.OPENSSL_PASSWORD }} | |
| run: echo "${STREAM_KEY}" | openssl enc -e -aes-256-cbc -a -pbkdf2 -iter 100000 -k "${PASSWORD}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.