-
Notifications
You must be signed in to change notification settings - Fork 109
[V5] Replace StreamCollection and LazyCachedMapCollection with Array #993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
laevandus
wants to merge
7
commits into
v5
Choose a base branch
from
v5-remove-stream-collection-lazy-cached-map-collection
base: v5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b678d07
Replace StreamCollection and LazyCachedMapCollection with Array
laevandus 4a6bdc3
Merge branch 'v5' into v5-remove-stream-collection-lazy-cached-map-co…
laevandus a56cbd1
Merge branch 'v5' into v5-remove-stream-collection-lazy-cached-map-co…
laevandus d484323
Merge branch 'v5' into v5-remove-stream-collection-lazy-cached-map-co…
laevandus f7ab132
Merge branch 'v5' into v5-remove-stream-collection-lazy-cached-map-co…
laevandus 3695cd7
Merge branch 'v5' into v5-remove-stream-collection-lazy-cached-map-co…
laevandus f0fe099
Merge branch 'v5' into v5-remove-stream-collection-lazy-cached-map-co…
laevandus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ import StreamChat | |
/// - messages, the collection of updated messages. | ||
func dataSource( | ||
channelDataSource: ChannelDataSource, | ||
didUpdateMessages messages: LazyCachedMapCollection<ChatMessage>, | ||
didUpdateMessages messages: [ChatMessage], | ||
changes: [ListChange<ChatMessage>] | ||
) | ||
|
||
|
@@ -35,7 +35,7 @@ import StreamChat | |
var delegate: MessagesDataSource? { get set } | ||
|
||
/// List of the messages. | ||
var messages: LazyCachedMapCollection<ChatMessage> { get } | ||
var messages: [ChatMessage] { get } | ||
|
||
/// Determines whether all new messages have been fetched. | ||
var hasLoadedAllNextMessages: Bool { get } | ||
|
@@ -82,8 +82,8 @@ class ChatChannelDataSource: ChannelDataSource, ChatChannelControllerDelegate { | |
let controller: ChatChannelController | ||
weak var delegate: MessagesDataSource? | ||
|
||
var messages: LazyCachedMapCollection<ChatMessage> { | ||
controller.messages | ||
var messages: [ChatMessage] { | ||
Array(controller.messages) | ||
} | ||
|
||
var hasLoadedAllNextMessages: Bool { | ||
|
@@ -166,8 +166,8 @@ class MessageThreadDataSource: ChannelDataSource, ChatMessageControllerDelegate | |
|
||
weak var delegate: MessagesDataSource? | ||
|
||
var messages: LazyCachedMapCollection<ChatMessage> { | ||
var replies = messageController.replies | ||
var messages: [ChatMessage] { | ||
var replies = Array(messageController.replies) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here |
||
if let message = messageController.message, replies.last != message { | ||
replies.append(message) | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2659,7 +2659,6 @@ | |
8434E58127707F19001E1B83 /* GridMediaView.swift in Sources */, | ||
ADE0F5662CB962470053B8B9 /* ActionBannerView.swift in Sources */, | ||
84BB4C4C2841104700CBE004 /* MessageListDateUtils.swift in Sources */, | ||
82D64BE72AD7E5B700C5C79E /* ImageTask.swift in Sources */, | ||
84EB881A2E8ABA610076DC17 /* ParticipantInfoView.swift in Sources */, | ||
8465FDC12746A95700AF091E /* NoChannelsView.swift in Sources */, | ||
C14A465B284665B100EF498E /* SDKIdentifier.swift in Sources */, | ||
|
@@ -3856,7 +3855,7 @@ | |
isa = XCRemoteSwiftPackageReference; | ||
repositoryURL = "https://github.com/GetStream/stream-chat-swift.git"; | ||
requirement = { | ||
branch = v5; | ||
branch = "v5-remove-stream-collection-lazy-cached-map-collection"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Revert before merge |
||
kind = branch; | ||
}; | ||
}; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why's an array needed here?