Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the project architecture by consolidating configuration and client code and removing legacy API implementations. Key changes include:
- Introduction of new configuration and constants modules under src/khaya.
- Removal of outdated API modules and setup.py in favor of a consolidated client.
- Updates to documentation and CI workflows to reflect the new project structure.
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/khaya/constants.py | Added global constants (TIMEOUT and RETRY_ATTEMPTS). |
| src/khaya/config.py | Introduced Pydantic-based settings for API configuration. |
| src/khaya/init.py | Updated module exports to expose the KhayaClient. |
| setup.py | Removed outdated setup script. |
| pyproject.toml | Updated packaging configuration and added new dependencies. |
| mkdocs.yml | Revised navigation to include KhayaClient documentation. |
| khaya/* (tts_api, translation_api, base_api, asr_api, init.py) | Removed legacy API modules as part of the architecture reorganization. |
| examples/load_and_preprocess_parallel_dataset.py | Adjusted library import casing for consistency. |
| docs/api-reference/khaya/*.md | Updated API reference documentation to match current client exposure. |
| Kasa/init.py | Removed legacy module in favor of a unified namespace. |
| .github/workflows/test.yml | Revised CI configuration with updated branch names and dependency setup. |
Comments suppressed due to low confidence (2)
.github/workflows/test.yml:19
- [nitpick] The downgrade from actions/checkout@v4 to @v2 may reduce stability and feature support; consider using the more recent version unless there is a specific reason for the change.
- uses: actions/checkout@v2
examples/load_and_preprocess_parallel_dataset.py:8
- [nitpick] The change from 'Kasa.Preprocessing' to 'kasa.Preprocessing' implies a naming convention update; ensure consistency across the project and documentation.
from kasa.Preprocessing import Preprocessing # note form of library import
joelbudu
approved these changes
Apr 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.