forked from columnflow/columnflow
-
Notifications
You must be signed in to change notification settings - Fork 2
classes for easy access to CMS color schemes + custom ones #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JanvanderLinden
wants to merge
137
commits into
master
Choose a base branch
from
color_schemes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added submodules for ghent_template
… environments (essential to debugging)
For Lumi files: normtag from lumi pog github (cloned into the modules), everything else from https://cms-service-dqmdc.web.cern.ch/CAF/certification. All other POG jsons from the jsonpog-integration gitlab (cloned into the modules)
Lepton mva
…be implemented as method)
…ward seems to breakdown when number of concatenated arrays exceeds 2 ** 7
concatenate large amount of arrays
update to custom_lfn function
JulesVandenbroeck
approved these changes
Jan 13, 2025
Collaborator
JulesVandenbroeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request seems to be fine for me. 2 small question:
- is if the number of grey shades is arbitrary?
- in my opinion
lightblue,darkorange, andlightvioletis a better choice but not a request to change if you don't want to.
While the linting tests fail it should still be fine in the master so no issues there.
Cheers, Jules
61ab55e to
ecb6aec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import CMS CAT color schemes via
Hex code of colors can be accessed e.g. via
c.red, etc for defining plotting color processes.Alternatively can also directly import as
yields the same.
Also supplies a gradient of grey colors
c.grey, c.grey1, ... c.grey5in addition to the CAT-defined colors.Also allows for accessing colors via an index, e.g.
c[0], etc.