Open
Conversation
…he execute methods initialize the state themselves.
|
@Ghostkeeper Can you review/push version. I can confirm the patch works for me. |
icecreammatt
approved these changes
May 15, 2025
There was a problem hiding this comment.
Can confirm these fixes worked for me. In addition to these I had to create a manifest file for it to load. To test I cloned this fork and then added the manifest to the io_mesh_3mf folder. Then I zipped this all up and imported the zip. I tested with Blender 4.4.3 on Asahi Linux.
blender_manifest.toml
schema_version = "1.0.0"
id = "ID3mf"
version = "1.0.0"
name = "3mf"
tagline = "3mf"
maintainer = "Ghostkeeper"
type = "add-on"
tags = ["Modeling"]
blender_version_min = "4.2.0"
license = ["GPL-2.0-or-later"]
|
After modifying the files it wouldn't install the add-on. I Had to add the manifest file as @icecreammatt pointed out and it worked fine.
|
humzasami
approved these changes
Sep 20, 2025
thomraider12
approved these changes
Sep 30, 2025
thomraider12
left a comment
thomraider12
left a comment
There was a problem hiding this comment.
I'd like these changes to be made, since this is a bug
itsasolid4fromme
approved these changes
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes the overridden init methods, which are now forbidden (and unnecessary as the execute methods initialize the state themselves.)