Skip to content

Fix missing pool_config import issue and provide default database pool configuration. #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix missing pool_config import issue and provide default database pool configuration. #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40a689b
fix: resolve missing import for pool_config and add default configura…
KarthikeyaKollu Nov 12, 2025
2d49f84
updated config
KarthikeyaKollu Nov 12, 2025
a58907f
Merge branch 'main' into fix-config-import-issue
KarthikeyaKollu Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions memori/config/pool_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
DEFAULT_POOL_SIZE = 2
DEFAULT_MAX_OVERFLOW = 3
DEFAULT_POOL_TIMEOUT = 30
DEFAULT_POOL_RECYCLE = 3600
DEFAULT_POOL_PRE_PING = True
2 changes: 1 addition & 1 deletion memori/database/sqlalchemy_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from sqlalchemy.exc import SQLAlchemyError
from sqlalchemy.orm import sessionmaker

from ..config.pool_config import pool_config
from ..config import pool_config
from ..utils.exceptions import DatabaseError
from ..utils.pydantic_models import (
ProcessedLongTermMemory,
Expand Down