Fixed various (minor) socket issues.#623
Open
TangoBravo64 wants to merge 1 commit intoGideonZ:masterfrom
Open
Conversation
- Several (corner) cases where 0 was incorrectly not treated as a valid socket descriptor. - Fixed handling of CFG_MODEM_LISTEN_PORT in modem.cc: when sscanf failed (user configured an empty or non-numeric string value), an undefined value was used as the port number. - Entering an empty string, 0, or any non-numeric value for CFG_MODEM_LISTEN_PORT now no longer starts the listener thread (as port 0 is invalid anyway).
TangoBravo64
force-pushed
the
socket0issues
branch
from
13a8be8 to
391676f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I checked firmware sources using sockets, and found some more places where 0 was not properly handled as a valid socket descriptor. Nothing "dramatic" (as with the MicroHttpServer), but easy to fix.
Also, an undefined value was used for the port number in modem.cc, when an empty or non-numeric string was entered for CFG_MODEM_LISTEN_PORT, so when sscanf failed.
Entering an empty string, 0, or any non-numeric value for CFG_MODEM_LISTEN_PORT now no longer starts the modem's listener thread (as port 0 is invalid anyway).