HA script: broadcast UDP events by default#22
Open
elrodro83 wants to merge 1 commit intoGiftie:masterfrom
elrodro83:master
Open
HA script: broadcast UDP events by default#22elrodro83 wants to merge 1 commit intoGiftie:masterfrom elrodro83:master
elrodro83 wants to merge 1 commit intoGiftie:masterfrom
elrodro83:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It wouldn't hurt to have the HA scrit have the broadcast UDP that is mentioned in http://kodi.wiki/view/Add-on:Cinema_Experience#Home_Automation_Integration implemented by default.
I'm working on another add-on that might benefit from this default behavior also, while avoiding the manual and error prone step of manually editing the file. Having the HA file automatically generated from my add-on was rejected from the xbmc add on managers, so i went ahead and changed the cinema experience code itself.
If you want, checkout my add-on that will make use of this, it's https://github.com/elrodro83/theater-lights