Skip to content

Conversation

@GiggleLiu
Copy link
Owner

fix #154

This PR provides some new APIs to convert EXTREMA type of constraints to hard constraints.

CircuitSATHard
SatisfiabilityHard
KSatisfiabilityHard
ColoringHard

@GiggleLiu
Copy link
Owner Author

@isPANN Wondering if this could fix your issue.

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.45%. Comparing base (8b29f55) to head (cf6557d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   94.43%   94.45%   +0.02%     
==========================================
  Files          40       40              
  Lines        1778     1786       +8     
==========================================
+ Hits         1679     1687       +8     
  Misses         99       99              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@isPANN
Copy link

isPANN commented Sep 22, 2025

Looks great! And should we overload reduceto? The current code in BooleanInference uses this API.

@GiggleLiu
Copy link
Owner Author

GiggleLiu commented Sep 23, 2025

Looks great! And should we overload reduceto? The current code in BooleanInference uses this API.

I do not think so, since it is a unified API for every problem reduction, please change the downstream code accordingly. Changing the API is very tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reduceto(::Type{<:CircuitSAT}, f::Factoring) should support use_constraints keyword argument

2 participants