Skip to content

Conversation

@Giglium
Copy link
Owner

@Giglium Giglium commented Dec 12, 2025

No description provided.

@Giglium Giglium force-pushed the imp branch 3 times, most recently from c50e9cc to 1dc5926 Compare December 15, 2025 18:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables automated testing for Python 3.7 by adding a new GitHub Actions workflow and updating the Makefile to include the new workflow in local testing.

  • Added a new GitHub Actions workflow test_legacy.yml specifically for testing Python 3.7 compatibility
  • Updated the Makefile's act.test target to include the new legacy test workflow

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/test_legacy.yml New workflow that tests the package on Python 3.7 using minimal dependencies (asyncmock and httpx[brotli]) installed via pip, bypassing uv which requires Python >= 3.8
Makefile Added the new legacy test workflow to the act.test target for local workflow testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

with:
python-version: "3.7"

- name: Run tests
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two steps have the same name "Run tests". This creates confusion and makes it difficult to identify which step failed in CI logs. The first step (line 32) should be renamed to reflect that it installs dependencies, not runs tests.

Suggested change
- name: Run tests
- name: Install dependencies

Copilot uses AI. Check for mistakes.
@Giglium
Copy link
Owner Author

Giglium commented Dec 15, 2025

@copilot can you fix the CI problem by only modify the file test_legacy.yml

Copy link

Copilot AI commented Dec 15, 2025

@Giglium I've opened a new pull request, #140, to work on those changes. Once the pull request is ready, I'll request review from you.

@Giglium
Copy link
Owner Author

Giglium commented Dec 16, 2025

I closed the PR since the compatibility with Python 3.7 is too much effort for a deprecated version.

@Giglium Giglium closed this Dec 16, 2025
@Giglium Giglium deleted the imp branch December 16, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants