-
Notifications
You must be signed in to change notification settings - Fork 6
Add docker to the dev container #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add docker to the dev container #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Docker support to the development container by including the docker-in-docker feature, which is the recommended approach for enabling Docker functionality within a devcontainer.
- Adds the
ghcr.io/devcontainers/features/docker-in-docker:2feature with the latest version
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
smoke test |
Deployment Triggered 🚀kevinbackhouse, started a branch deployment to production (branch: You can watch the progress here 🔗 Details{
"type": "branch",
"environment": {
"name": "production",
"url": null
},
"deployment": {
"timestamp": "2025-11-25T08:33:36.262Z",
"logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19663204779"
},
"git": {
"branch": "5a3246d3abcd993ad465c554fa887abf891c6d71",
"commit": "5a3246d3abcd993ad465c554fa887abf891c6d71",
"verified": true,
"committer": "web-flow",
"html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/commit/5a3246d3abcd993ad465c554fa887abf891c6d71"
},
"context": {
"actor": "kevinbackhouse",
"noop": false,
"fork": true,
"comment": {
"created_at": "2025-11-25T08:33:23Z",
"updated_at": "2025-11-25T08:33:23Z",
"body": "smoke test",
"html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/pull/91#issuecomment-3574363269"
}
},
"parameters": {
"raw": null,
"parsed": null
}
} |
Deployment Results ✅kevinbackhouse successfully deployed branch Details{
"status": "success",
"environment": {
"name": "production",
"url": null
},
"deployment": {
"id": 3366799818,
"timestamp": "2025-11-25T08:38:10.170Z",
"logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19663204779",
"duration": 274
},
"git": {
"branch": "5a3246d3abcd993ad465c554fa887abf891c6d71",
"commit": "5a3246d3abcd993ad465c554fa887abf891c6d71",
"verified": true
},
"context": {
"actor": "kevinbackhouse",
"noop": false,
"fork": true
},
"reviews": {
"count": 1,
"decision": "APPROVED"
},
"parameters": {
"raw": null,
"parsed": null
}
} |
|
smoke test |
Deployment Triggered 🚀kevinbackhouse, started a branch deployment to production (branch: You can watch the progress here 🔗 Details{
"type": "branch",
"environment": {
"name": "production",
"url": null
},
"deployment": {
"timestamp": "2025-11-25T09:52:12.229Z",
"logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19665332723"
},
"git": {
"branch": "4d62b30dc2cbcf86a0fb7510d2705b0d19c701c4",
"commit": "4d62b30dc2cbcf86a0fb7510d2705b0d19c701c4",
"verified": true,
"committer": "web-flow",
"html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/commit/4d62b30dc2cbcf86a0fb7510d2705b0d19c701c4"
},
"context": {
"actor": "kevinbackhouse",
"noop": false,
"fork": true,
"comment": {
"created_at": "2025-11-25T09:51:54Z",
"updated_at": "2025-11-25T09:51:54Z",
"body": "smoke test",
"html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/pull/91#issuecomment-3574747024"
}
},
"parameters": {
"raw": null,
"parsed": null
}
} |
Deployment Results ✅kevinbackhouse successfully deployed branch Details{
"status": "success",
"environment": {
"name": "production",
"url": null
},
"deployment": {
"id": 3367224221,
"timestamp": "2025-11-25T09:59:07.532Z",
"logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19665332723",
"duration": 415
},
"git": {
"branch": "4d62b30dc2cbcf86a0fb7510d2705b0d19c701c4",
"commit": "4d62b30dc2cbcf86a0fb7510d2705b0d19c701c4",
"verified": true
},
"context": {
"actor": "kevinbackhouse",
"noop": false,
"fork": true
},
"reviews": {
"count": 1,
"decision": "APPROVED"
},
"parameters": {
"raw": null,
"parsed": null
}
} |
docker isn't included in the base image. This is the recommended way to add it.