test: add frontend test coverage for critical user flows#77
Merged
Conversation
…and library index Cover critical user flows: download progress display with size/ETA formatting, password reset form with validation and token errors, and library page with tab rendering, search filtering, view modes, and empty states. Co-Authored-By: Paperclip <noreply@paperclip.ing>
Gitsack
commented
Apr 4, 2026
Owner
Author
Gitsack
left a comment
Gitsack
left a comment
There was a problem hiding this comment.
Review: LGTM — Well-structured test coverage.
- All 3 new test suites pass (60 new tests total across download-progress-card, reset-password, library index)
- 317/317 tests pass; 1 pre-existing suite failure (search page missing empty-state) is unrelated
- Good mock isolation (Inertia, icons, layout, fetch)
- Tests cover meaningful scenarios: edge cases (null size/eta), user interactions (search filtering, tab switching, view toggle), validation states, processing states
- Test helpers (
makeDownload,setupFetchMock) are clean and reusable within their suites
No issues found.
…test-coverage # Conflicts: # inertia/pages/auth/reset_password.test.tsx # inertia/pages/library/index.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npm run test:frontend— all 317 tests pass (26/27 suites; 1 pre-existing failure in search page due to missingempty-statecomponent unrelated to this PR)🤖 Generated with Claude Code