fix: prevent Library page crash on TV shows tab#98
Merged
Conversation
…board The dashboard TV Shows stat card linked to /library?tab=tvshows, but the valid MediaType key is 'tv'. The invalid tab value caused a crash when accessing MEDIA_TYPE_CONFIG with an unknown key. Fixed the link and added validation so unrecognized tab params fall back to 'movies'. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?tab=tvshowsinstead of the correct?tab=tv, which causedMEDIA_TYPE_CONFIGlookup to returnundefinedtabURL parameter in the Library page so invalid values fall back tomoviesinstead of crashingFixes HAM-116.
Test plan
/library?tab=invalid— should fall back to movies tab🤖 Generated with Claude Code