Security-focused PHPstan #916
Open
+152
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…natives and allow execution calls in robo-components. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
amitaibu
reviewed
Oct 10, 2025
| $this->taskReplaceInFile('.bootstrap/.ddev/config.yaml') | ||
| ->from('8880') | ||
| ->to((string) rand(6000, 8000)) | ||
| ->to((string) random_int(6000, 8000)) |
Member
Author
There was a problem hiding this comment.
Here, it would be fine with rand. This is just a demonstration of a security-focused ruleset for phpstan. If we stick to random_int, we can be sure the numbers are not predictable. At some places, it matters a lot.
Member
Author
There was a problem hiding this comment.
See Slack devstuff for more context.
mariano-dagostino
requested changes
Oct 28, 2025
phpstan.neon
Outdated
| - RoboFile.php | ||
| - | ||
| function: 'popen()' | ||
| message: 'use Symfony Process instead' |
Collaborator
There was a problem hiding this comment.
Should we link to the component page? https://symfony.com/doc/current/components/process.html
Member
Author
|
@mariano-dagostino I added some more rules and adapted the custom code, good point! |
amitaibu
reviewed
Oct 30, 2025
| function: 'print_r()' | ||
| message: 'use some logger instead' | ||
| allowParamsAnywhere: | ||
| 2: true |
Member
Author
There was a problem hiding this comment.
✅ Allowed: print_r($var, true) - returns output as string (for logging)
❌ Disallowed: print_r($var) or print_r($var, false) - outputs directly to screen
mariano-dagostino
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.