Robo command for hotfix deployment

[iswariya]

#946

TB: 1h(1h/2h)

[AronNovak]

Looks good. A few observations:

• let's use the already defined .pantheon directory for this, like other deployments
• if the hotfix affects the theme, like PCSS, it won't work. We need extra handling for that
• use rsync command for the copying, so the exclusion logic won't differ from the full deploy process.

[amitaibu]

@codex address comments

[chatgpt-codex-connector]

Summary

• Hotfix deployments now reuse the existing .pantheon checkout, ensure it is clean/up to date, and commit/push changes from that repository while syncing files via rsync with the standard exclusion list. robo-components/DeploymentTrait.phpL821-L934
• Theme-related changes in hotfixes trigger a compile of the theme assets in the hotfix worktree so PCSS updates are included before syncing to Pantheon. robo-components/DeploymentTrait.phpL885-L909
• Hotfix cleanup now removes the temporary worktree and prunes stale worktree references to keep the repository tidy. robo-components/DeploymentTrait.phpL981-L992

Testing

• ⚠️ Not run (not requested)

View task →

[amitaibu]

PR created by codex - #953

@iswariya see if it helps you

[iswariya]

@amitaibu Yes its helps. We can merge it to this PR.

[dipakmdhrm]

I think it would be useful if this throws a warning message to user saying something llke 'Have you ensured that the hotfix branch should be branched from last deployed tag' to help developer ensure that they're not merging anything unwanted. Eg. other issues already merged to the main branch.

Message could be something better of course.

[dipakmdhrm]

I think it would be useful if this throws a warning message to user saying something llke 'Have you ensured that the hotfix branch should be branched from last deployed tag' to help developer ensure that they're not merging anything unwanted. Eg. other issues already merged to the main branch.

Message could be something better of course.

On second thought, aren't hotfix already possible using:

git checkout hotfix-branch
git tag 1.x.x-hotfix
ddev robo deploy:tag-pantheon --no-interaction 1.x.x-hotfix  master

Followed by ddev robo deploy:pantheon-sync live for live deploy?

And then pushing tag to GH to create the hotfix release notes.

[amitaibu]

We can merge it to this PR.

Go ahead, you don't need me for this :)

[iswariya]

On second thought, aren't hotfix already possible using:

git checkout hotfix-branch
git tag 1.x.x-hotfix
ddev robo deploy:tag-pantheon --no-interaction 1.x.x-hotfix  master

Followed by ddev robo deploy:pantheon-sync live for live deploy?

And then pushing tag to GH to create the hotfix release notes.

@AronNovak Could you please provide your suggestions on this approach?

[AronNovak]

I am wondering if it makes sense in hotfix content. I think this is not the case.
We cannot get the true diff like this, as main is typically not on LIVE, that's why we hotfix. Likely we could replace this with a check on Pantheon repo, where we compare with the latest live tag.

[AronNovak]

perhaps we should also cleanup in a finally block of a try-catch

[AronNovak]

Suggested change

	$this->say("Step 3: Copying changed files to Pantheon repository...");
	$this->say("Step 3: Syncing hotfix branch to Pantheon repository...");

[AronNovak]

Indeed we can already do this, as @dipakmdhrm pointed out correctly, but if we build safeguards into the process, as suggested above, it can still bring value likely.