Optimize phpcs CI execution and improve output clarity

.ddev/web-build/Dockerfile

@@ -11,6 +11,7 @@ RUN set -eux; \
       --no-install-recommends \
       --no-install-suggests \
       optipng \
+      parallel \
       jpegoptim; \
     apt-get clean; \
     rm -rf /var/lib/apt/lists/*

.travis.yml

@@ -37,6 +37,10 @@ jobs:
         - PHP_MEMORY_LIMIT=2G ./vendor/bin/phpstan --no-progress analyse -c phpstan.neon
 
     - stage: Lint
+      addons:
+        apt:
+          packages:
+          - parallel
       name: Drupal coding standard
       script:
         - composer install || travis_terminate 1;

robo-components/PhpcsTrait.php

@@ -17,15 +17,7 @@ trait PhpcsTrait {
    *   successful.
    */
   public function phpcs(): ?ResultData {
-    $standards = [
-      'Drupal',
-      'DrupalPractice',
-    ];
-
-    $commands = [
-      'phpcbf',
-      'phpcs',
-    ];
+    $standards = 'Drupal,DrupalPractice';
 
     $directories = [
       'modules/custom',
@@ -37,26 +29,52 @@ public function phpcs(): ?ResultData {
       'sites/bot_trap_protection.php',
       '../phpstan-rules',
       '../.bootstrap-fast.php',
+      '../scripts',
     ];
 
-    $error_code = NULL;
+    $arguments = "--standard=$standards -p --ignore=" . self::$themeName . "/dist,node_modules,.parcel-cache --colors --extensions=php,module,inc,install,test,profile,theme,css,yaml,txt,md";
 
-    foreach ($directories as $directory) {
-      foreach ($standards as $standard) {
-        $arguments = "--parallel=8 --standard=$standard -p --ignore=" . self::$themeName . "/dist,node_modules,server_default_content/content --colors --extensions=php,module,inc,install,test,profile,theme,css,yaml,yml,txt,md";
-
-        foreach ($commands as $command) {
-          $result = $this->_exec("cd web && ../vendor/bin/$command $directory $arguments");
-          if (empty($error_code) && !$result->wasSuccessful()) {
-            $error_code = $result->getExitCode();
-          }
-        }
+    // Step 1: Auto-fix what can be fixed (only if not in CI).
+    // In CI, phpcbf can't commit changes, so we skip it for better performance.
+    $is_ci = !empty(getenv('CI'));
+    if (!$is_ci) {
+      $this->say('Running phpcbf to auto-fix coding standard violations...');
+      $command_list = [];
+      foreach ($directories as $directory) {
+        // Phpcbf exits with non-zero even on success when it fixes files.
+        // We don't fail on phpcbf errors since phpcs will catch real issues.
+        $command_list[] = "cd web && ../vendor/bin/phpcbf $directory $arguments || true";
       }
+
+      $commands_file = tempnam(sys_get_temp_dir(), 'phpcbf_commands');
+      file_put_contents($commands_file, implode("\n", $command_list));
+
+      $this->_exec("parallel -j+0 < $commands_file");
+      unlink($commands_file);
     }
 
-    if (!empty($error_code)) {
-      return new ResultData($error_code, 'PHPCS found some issues');
+    // Step 2: Check for remaining violations.
+    $this->say('Running phpcs to check for coding standard violations...');
+    $command_list = [];
+    foreach ($directories as $directory) {
+      $command_list[] = "cd web && ../vendor/bin/phpcs $directory $arguments";
+    }
+
+    $commands_file = tempnam(sys_get_temp_dir(), 'phpcs_commands');
+    file_put_contents($commands_file, implode("\n", $command_list));
+
+    $result = $this->_exec("parallel -j+0 --halt now,fail=1 < $commands_file");
+    unlink($commands_file);
+
+    if (!$result->wasSuccessful()) {
+      $this->say('');
+      $this->yell('PHPCS found coding standard violations!', 40, 'red');
+      $this->say('Please review the errors above and fix them.');
+      return new ResultData($result->getExitCode(), 'PHPCS found coding standard violations');
     }
+
+    $this->say('');
+    $this->say('✓ No coding standard violations found!');
     return NULL;
   }