Fix Travis CI and add Drupal coding standards #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix Travis CI PHP version issue by adding dist: jammy - Add drupal/coder dependency for Drupal coding standards - Update composer scripts to use Drupal and DrupalPractice standards - Fix all existing code to comply with Drupal coding standards - Auto-fixed 962 code style violations across 5 files - Added missing documentation for remaining violations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Updated ReleaseNotesTasks to use Result::success() and Result::error() methods - Fixed ReleaseNotesTasksTest by mocking generateReleaseNotes method to avoid container dependency - Updated ReleaseNotesGeneratorTest to use proper mock objects instead of PHPUnit mocks - Fixed numeric vs string comparisons in test assertions throughout test suite 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Introduce explicit stages: lint → analysis → test - Remove global script section in favor of job-specific scripts - Only run tests if linting passes - Add descriptive job names for better CI visibility - Organize pipeline flow: code standards → static analysis → tests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add proper documentation to all empty doc comments with method descriptions, parameters, and return values - Fix anonymous class constructor calls to include parentheses - Rename _exec method to execCommand to follow camelCase naming convention - Add proper documentation for all member variables with type annotations - Improve code formatting and consistency throughout test files - All coding standards now pass with zero violations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add phpstan/phpstan ^2.1 as dev dependency - Fix all array type annotations with proper generics - Add missing return type declarations - Replace Symfony Response constants with numeric values - Remove unused properties and parameters - Fix parameter type declarations in test files All 25 PHPStan level 6 errors resolved while maintaining backward compatibility and test coverage. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
mariano-dagostino
requested changes
Jun 19, 2025
mariano-dagostino
left a comment
mariano-dagostino
left a comment
There was a problem hiding this comment.
@AronNovak It seems there is still some phpcs things to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dist: jammyfor Ubuntu 22.04 compatibilitydrupal/coderdependency and configured phpcs to use Drupal coding standardsTest plan
🤖 Generated with Claude Code