Skip to content

Conversation

@scala-steward
Copy link
Contributor

Updates org.scala-js:scalajs-dom from 0.9.8 to 2.0.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (0.9.8).
You might want to review and update them manually.

html/src/main/scala/org/lrng/binding/AttributeFactories.scala
Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-js", artifactId = "scalajs-dom" } ]

labels: library-update, semver-major, old-version-remains

@romansky
Copy link

Can this pull be merged please?

@Atry
Copy link
Contributor

Atry commented Dec 15, 2021

This is not a backward compatible change. We should update the major version of html.scala

@romansky
Copy link

romansky commented Dec 15, 2021 via email

@romansky
Copy link

pull request with relevant changes #174
@Atry I'm fine with a major version change :)
Thanks for the great lib!

@scala-steward
Copy link
Contributor Author

Superseded by #177.

@scala-steward scala-steward deleted the update/scalajs-dom-2.0.0 branch December 31, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants