-
Notifications
You must be signed in to change notification settings - Fork 0
glimpse-GM-PromptCard-4 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…rompt Tag, Installed expo-image package
…Added countdown functionality, fixed auto height and width issue, adjusted boldness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work Andrew!
Thank you for creating separate components for the pomrptCardTag and the PromptCardCountdown in order to be used for the rest of the pages. My one comment on the PromptCardCountdown.tsx:
- Simplify and reduce the code by reducing the number of useEffects. I think we can keep track whether it's running without the constant so we can combine the first. and third useEffect
Great work with providing the skeleton navigation for the answer button. We'll prompt it to navigate to the upload page once we get that developed.
I'm going to go in and test the component as well. Before and after the new changes.
…che beginning functions for performance, Removed isRunning state
|
Pushed new commit where the useEffects were consolidated. |
JasonMun7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Andrew! This PromptCardCountdown looks a lot better! I'll move this into testing!
Finished UI Skeleton of Prompt Card
Notes:
Packages Added: