Skip to content

Conversation

@AndrewCheung360
Copy link
Member

Finished UI Skeleton of Prompt Card

Notes:

  • Current skeleton is based off a modified design and figma font has not yet been used, so subject to change
  • No button functionality added yet
  • startTime should be in ISO Date-Time format eg. 2024-04-22T15:33:27, this should auto adjust to local time of device (not tested)
  • duration should be in seconds eg. 24 hr --> 86400 sec.
  • Tag, which represents type of response should start with capital letter.

Packages Added:

  • expo-image: better Image support than react native image mainly for svgs

@AndrewCheung360 AndrewCheung360 requested a review from JasonMun7 July 2, 2024 01:20
@AndrewCheung360 AndrewCheung360 added the enhancement New feature or request label Jul 2, 2024
Copy link
Collaborator

@JasonMun7 JasonMun7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work Andrew!

Thank you for creating separate components for the pomrptCardTag and the PromptCardCountdown in order to be used for the rest of the pages. My one comment on the PromptCardCountdown.tsx:

  • Simplify and reduce the code by reducing the number of useEffects. I think we can keep track whether it's running without the constant so we can combine the first. and third useEffect

Great work with providing the skeleton navigation for the answer button. We'll prompt it to navigate to the upload page once we get that developed.

I'm going to go in and test the component as well. Before and after the new changes.

…che beginning functions for performance, Removed isRunning state
@AndrewCheung360
Copy link
Member Author

Pushed new commit where the useEffects were consolidated.

Copy link
Collaborator

@JasonMun7 JasonMun7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Andrew! This PromptCardCountdown looks a lot better! I'll move this into testing!

@AndrewCheung360 AndrewCheung360 self-assigned this Jul 6, 2024
@AndrewCheung360 AndrewCheung360 requested review from JasonMun7 and dorawengg and removed request for JasonMun7 October 18, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants