Missing "external" statements in GA Fortran header #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaypanyala
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Global Arrays team,
Thank you kindly for your work on maintaining global arrays and for the new releases this year, I appreciate all your hard work on this.
I noticed that version 5.9 enables the the new method
ga_initialize_commto set up GA attached to an existing MPI Comm, rather than assuming the use ofMPI_COMM_WORLDand I have been trying to use this method in a Fortran code. So far I have been getting good results with this, but I noticed that unlike other GA functions a couple of the new methods have noexternalstatement in the GA Fortran header file. Hence, theexternalstatements have to be added by hand when the functions are used.It looks like the testing of this feature has been using C rather than Fortran, so I thought I would feed this patch back upstream. Just let me know if I have misunderstood something -- I don't have much experience with Fortran header files myself.
The Fortran header file was updated with these methods in 326306d.
Thanks,
Tom