Open
Conversation
…hless into FaithKimAudio
SiennaC
requested changes
Dec 5, 2017
Collaborator
SiennaC
left a comment
SiennaC
left a comment
There was a problem hiding this comment.
Did you make any changes to the scene that were not for testing? The actual vat sfx we'll probably do differently - the trigger areas will be for other things, like footsteps on the ladder or in the blood puddle, once we have audio for it.
Assets/Scripts/Audio/RTPCTrigger.cs
Outdated
| private float rtpcExitValue; | ||
|
|
||
| private void OnTriggerEnter2D(Collider2D collision) { | ||
| Debug.Log ("Enter"); |
Collaborator
There was a problem hiding this comment.
Please remove debug statements.
Collaborator
Author
There was a problem hiding this comment.
I have not made any changes to the scene other than the trigger guard dlg. Will triggers be created for the ladder and the blood puddle? If so, then I'm assuming that we will be able to attach the RTPCTrigger script to those trigger areas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested the RPTCTrigger script on DistanceToVAT game param for Vat, and it works!