Conversation
|
@codex resolve this |
|
Summary
Testing
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (defun sg:plist-number (params key default) | ||
| "Return numeric value from PARAMS plist by KEY, falling back to DEFAULT." | ||
| (sg:val-or-default (cdr (assoc key params)) default)) |
There was a problem hiding this comment.
Parse property lists instead of ignoring non-interactive args
Non-interactive SGEARMAKE calls now accept a property list like (:module 2 :teeth 12 …), but sg:plist-number retrieves values with assoc, which only works on association lists of conses. With the documented plist (e.g., (SGEARMAKE '(:module 1 :teeth 10 ...))), each assoc returns nil so every parameter falls back to the defaults (module 2, teeth 24, etc.), meaning callers cannot override the inputs and the new non-interactive mode silently ignores all provided values.
Useful? React with 👍 / 👎.
|
@codex fix this merge conflict |
|
Summary
Testing
|
…efined-function-val-i-lytbvl
|
@codex fix this failed check, auto-load smoke test failed. Check the integrity of the check, if the check is functioning as intended, iterate and re-check until it passes. This pr shouldn't have been submitted with this failing. Run chmod +x tests/auto_load_test.sh |
Summary
Testing
|
Summary
Testing
Codex Task