-
Notifications
You must be signed in to change notification settings - Fork 0
Release: gcode 0.6.0, gsqz 0.4.1, gcore 0.1.0, ghook 0.1.0 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7cced9d
cb49094
bce13f7
f135736
25faa57
3419336
06a7c4b
ab7ae08
45223b8
33a361e
12b52f7
7eaae02
7d0ad7b
f3a1408
0ca108f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,42 @@ | ||||||||||||||||
| name: Release gobby-core | ||||||||||||||||
|
|
||||||||||||||||
| on: | ||||||||||||||||
| push: | ||||||||||||||||
| tags: | ||||||||||||||||
| - "gobby-core-v*" | ||||||||||||||||
|
|
||||||||||||||||
|
Comment on lines
+4
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tag trigger does not match the documented release tag prefix. Line 6 uses Suggested fix on:
push:
tags:
- - "gobby-core-v*"
+ - "gcore-v*"📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||
| permissions: | ||||||||||||||||
| contents: read | ||||||||||||||||
|
|
||||||||||||||||
| jobs: | ||||||||||||||||
| test: | ||||||||||||||||
| name: Test before release | ||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||
| steps: | ||||||||||||||||
| - uses: actions/checkout@v4 | ||||||||||||||||
|
|
||||||||||||||||
| - name: Install Rust toolchain | ||||||||||||||||
| uses: dtolnay/rust-toolchain@stable | ||||||||||||||||
| with: | ||||||||||||||||
| components: clippy | ||||||||||||||||
|
|
||||||||||||||||
| - name: Clippy | ||||||||||||||||
| run: cargo clippy -p gobby-core --all-targets -- -D warnings | ||||||||||||||||
|
|
||||||||||||||||
| - name: Run tests | ||||||||||||||||
| run: cargo test -p gobby-core | ||||||||||||||||
|
|
||||||||||||||||
| publish: | ||||||||||||||||
| needs: test | ||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||
|
|
||||||||||||||||
| steps: | ||||||||||||||||
| - uses: actions/checkout@v4 | ||||||||||||||||
|
|
||||||||||||||||
| - name: Install Rust toolchain | ||||||||||||||||
| uses: dtolnay/rust-toolchain@stable | ||||||||||||||||
|
|
||||||||||||||||
| - name: Publish gobby-core to crates.io | ||||||||||||||||
| run: cargo publish -p gobby-core | ||||||||||||||||
| env: | ||||||||||||||||
| CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }} | ||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,125 @@ | ||||||||||||||
| name: Release ghook | ||||||||||||||
|
|
||||||||||||||
| on: | ||||||||||||||
| push: | ||||||||||||||
| tags: | ||||||||||||||
| - "gobby-hooks-v*" | ||||||||||||||
|
|
||||||||||||||
|
Comment on lines
+3
to
+7
|
||||||||||||||
| push: | |
| tags: | |
| - "gobby-hooks-v*" | |
| push: | |
| tags: | |
| - "ghook-v*" |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/release-ghook.yml around lines 4 - 7, The workflow push
tag pattern uses "gobby-hooks-v*" but docs expect "ghook-v*", so update the push
-> tags pattern (the tag value currently "gobby-hooks-v*") to the correct
release prefix "ghook-v*" so pushes of tags like ghook-v... will trigger the
workflow; locate the tags entry in the release workflow and replace
"gobby-hooks-v*" with "ghook-v*".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow triggers on
gobby-core-v*tags, but the PR description/release instructions refer to agcore-v*prefix. This mismatch will cause publishes to not run when following the documented tag naming; please align either the workflow trigger or the documented release tag prefix.