Hotfix: gobby-hooks 0.1.1 (Windows extern block requires unsafe in edition 2024)

[joshwilhelmi]

Summary

Hotfix for gobby-hooks after the 0.1.0 release. Bumps to 0.1.1.

gobby-hooks 0.1.0 published to crates.io fine, but the
x86_64-pc-windows-msvc build target in the Release workflow failed
because edition 2024 requires extern "system" { ... } to be
unsafe extern "system" { ... }. The #[cfg(windows)] path in
crates/ghook/src/detach.rs was the only such block in the
workspace, and Mac/Linux dev never exercised it.

What's in the release

• Fixed — crates/ghook/src/detach.rs:36: unsafe extern "system" { fn FreeConsole() -> i32; }. One-line fix.
• Bumped — crates/ghook/Cargo.toml to 0.1.1.
• CHANGELOG — new [0.1.1] — gobby-hooks section above the existing [0.1.0] entry.

Test plan

• cargo build -p gobby-hooks clean
• cargo test -p gobby-hooks — 27 passing
• cargo clippy -p gobby-hooks --all-targets -- -D warnings clean
• After merge + gobby-hooks-v0.1.1 tag: Release ghook workflow succeeds across all 5 build targets and publishes a GitHub Release with binaries for all platforms

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Introduced gobby-hooks, a new hook dispatcher for sandbox-tolerant AI CLI integration with enqueue-first delivery and automatic retry capability.
  • Created gobby-core shared library providing standardized project discovery and daemon configuration across all Gobby tools.

• Bug Fixes

  • Hardened FTS5 search escaping in gcode to correctly handle special characters.
  • Suppressed low-savings marker in gsqz when it would increase output size.

• Improvements

  • Enhanced CI/CD with crate-specific release workflows and automated testing gates.
  • Refactored project discovery logic for code reuse across tools.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

A new shared gobby-core library crate extracts project-root discovery, bootstrap configuration, and daemon-URL helpers. A new gobby-hooks binary implements sandbox-tolerant hook dispatch by atomically enqueueing envelopes before posting to the daemon. Existing gcode is refactored to use shared helpers. CI/release workflows added for all crates.

Changes

Cohort / File(s)	Summary
Workflow CI/CD .github/workflows/ci.yml, .github/workflows/release-gcore.yml, .github/workflows/release-ghook.yml, .github/workflows/release-gcode.yml	Added clippy/test steps for new crates in CI. New release workflows for gobby-core and gobby-hooks with tag-based triggers, testing, and crates.io publishing. gobby-hooks includes multi-platform release builds (macOS/Linux/Windows) with artifact packaging. Release-gcode updated to depend on publish job.
New gobby-core Crate crates/gcore/Cargo.toml, crates/gcore/src/lib.rs, crates/gcore/src/project.rs, crates/gcore/src/bootstrap.rs, crates/gcore/src/daemon_url.rs	New shared library exposing project-root discovery, project-ID reading from .gobby/project.json, bootstrap endpoint parsing from ~/.gobby/bootstrap.yaml with default fallbacks, and HTTP daemon-URL composition with wildcard-host normalization. Includes unit tests for all modules.
New gobby-hooks Binary crates/ghook/Cargo.toml, crates/ghook/README.md, crates/ghook/src/main.rs, crates/ghook/src/cli_config.rs, crates/ghook/src/detach.rs, crates/ghook/src/diagnose.rs, crates/ghook/src/envelope.rs, crates/ghook/src/terminal_context.rs, crates/ghook/src/transport.rs, crates/ghook/schemas/inbox-envelope.v1.schema.json, crates/ghook/schemas/diagnose-output.v1.schema.json	New hook dispatcher binary supporting stdin→envelope→queue→POST flow. Includes CLI argument parsing (gobby-owned/diagnose/version modes), envelope creation with schema v1, atomic inbox writing via tmp+fsync+rename, optional terminal-context enrichment, POST delivery with cleanup on success, quarantine handling for malformed input, cross-platform detach (setsid/FreeConsole), and JSON schema validation.
gcode Refactoring crates/gcode/Cargo.toml, crates/gcode/src/project.rs, crates/gcode/src/config.rs, crates/gcode/src/commands/index.rs, crates/gcode/src/commands/init.rs, crates/gcode/src/commands/graph.rs, crates/gcode/src/search/fts.rs	Added dependency on gobby-core. Removed inline find_project_root and read_project_id implementations, now delegating to shared library. FTS LIKE pattern escaping hardened with dedicated escape_like function for %, _, \ metacharacters plus ESCAPE '\\' SQL clause. Graph command refactored to use empty_response_for_unresolved helper. Ambiguity logging simplified. Version bumped to 0.6.0.
gsqz Improvements crates/gsqz/Cargo.toml, crates/gsqz/src/compressor.rs, crates/gsqz/src/main.rs, crates/gsqz/src/primitives/group.rs	Added is_passthrough() method to classify strategies where output should be unmodified. Low-savings marker now suppressed when it would increase output size; marked cases return with /no-op strategy suffix. Main logic updated to use boolean predicate instead of string checks. Sort implementation simplified. Version bumped to 0.4.1.
Workspace/Manifest Files Cargo.toml, crates/gsqz/Cargo.toml	Workspace members expanded to include crates/gcore and crates/ghook. Release profile extended with size optimization (opt-level = "z") for gobby-hooks.
Documentation & Planning README.md, CHANGELOG.md, docs/guides/gcore-development-guide.md, docs/guides/ghook-development-guide.md, docs/guides/ghook-user-guide.md, docs/guides/gcode-development-guide.md, docs/guides/gsqz-user-guide.md, docs/plans/sandbox-tolerant-hooks-rust.md, docs/plans/sandbox-tolerant-hooks.md	Updated README to describe four Gobby CLI tools plus shared library. Comprehensive changelog documenting all version bumps and feature additions. New developer guides for gcore (module map, versioning, testing), ghook (control flow, detach, transport, terminal context, testing), and updated gcode guide. New user guides for ghook (CLI modes, inbox mechanics, troubleshooting) and gsqz (low-savings marker suppression). Planning documents detailing sandbox-tolerant hooks design and Rust-side implementation sequence.

Sequence Diagram

sequenceDiagram
    actor Host_CLI
    participant ghook_CLI as ghook (stdin mode)
    participant Inbox as ~/.gobby/hooks/inbox/
    participant Daemon as Gobby Daemon
    
    Host_CLI->>ghook_CLI: stdin (JSON hook payload)
    ghook_CLI->>ghook_CLI: Parse & validate JSON
    ghook_CLI->>ghook_CLI: Discover project root
    ghook_CLI->>ghook_CLI: Build Envelope struct
    ghook_CLI->>Inbox: Atomic write (tmp + fsync + rename)
    ghook_CLI->>ghook_CLI: Optional: detach from terminal
    ghook_CLI->>Daemon: POST /api/hooks/execute
    alt Success (2xx)
        Daemon-->>ghook_CLI: 2xx response
        ghook_CLI->>Inbox: Delete envelope file
        ghook_CLI-->>Host_CLI: exit 0 (or 2 if critical)
    else Failure (non-2xx/timeout)
        Daemon-->>ghook_CLI: error/timeout
        ghook_CLI->>Inbox: Leave envelope for replay
        ghook_CLI-->>Host_CLI: exit 0 (or 2 if critical)
    end
    
    Note over Inbox,Daemon: Daemon drains inbox files<br/>on next startup/tick

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related PRs

• Release: gcode 0.6.0, gsqz 0.4.1, gcore 0.1.0, ghook 0.1.0 #1: Introduces the same gobby-core and gobby-hooks crates with identical CI/release workflows, shared-library refactoring in gcode, and overlapping code edits (project helpers, FTS escaping, graph helper, gsqz passthrough).

Poem

🐰 New crates hop into place,
Hooks now spool with atomic grace—
No sandbox can hold them back,
Shared libraries fill the lack,
From daemon to CLI, we're on track! 🎯✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically identifies the main change: a Windows build fix for gobby-hooks 0.1.1 related to Rust edition 2024 extern block safety requirements.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dev

⚔️ Resolve merge conflicts

• Resolve merge conflict in branch dev

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[joshwilhelmi]

Reopening as PR from hotfix/ghook-0.1.1 \u2014 dev branch was based on the pre-rebase chain after PR #1 merged with rebase, so this PR's diff against main was conflicting. The fix is unchanged; new PR coming.

[Copilot]

Pull request overview

This PR expands the workspace to include a new sandbox-tolerant hook dispatcher (ghook / gobby-hooks) and a shared primitives crate (gobby-core), updates gcode and gsqz behavior/docs accordingly, and adjusts CI/release automation (in addition to the Windows edition-2024 unsafe extern hotfix noted in the PR description).

Changes:

• Added gobby-core (crates/gcore) for shared project discovery + bootstrap/daemon URL helpers, and migrated gcode call sites to use it.
• Added ghook (crates/ghook, package gobby-hooks) including spool-first transport, schemas, docs, and a release workflow; includes the Windows unsafe extern "system" fix.
• Updated gsqz low-savings behavior and reporting, hardened gcode LIKE escaping, and bumped crate versions + changelog/CI.

Reviewed changes

Copilot reviewed 41 out of 42 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
docs/plans/sandbox-tolerant-hooks.md	Adds detailed multi-CLI sandbox-tolerant hooks plan/spec.
docs/plans/sandbox-tolerant-hooks-rust.md	Rust-side handoff plan describing gobby-core + ghook approach.
docs/guides/gsqz-user-guide.md	Documents /no-op and marker suppression behavior in gsqz.
docs/guides/ghook-user-guide.md	New user-facing guide for installing/wiring/diagnosing ghook.
docs/guides/ghook-development-guide.md	New developer guide describing ghook architecture, schema, and internals.
docs/guides/gcore-development-guide.md	New developer guide defining gobby-core API and design constraints.
docs/guides/gcode-development-guide.md	Updates gcode docs to reference gobby-core extraction.
crates/gsqz/src/primitives/group.rs	Refactors grouping sort to use sort_by_key(Reverse(..)).
crates/gsqz/src/main.rs	Uses CompressionResult::is_passthrough() to unify header/reporting rules.
crates/gsqz/src/compressor.rs	Implements low-savings marker suppression and /no-op strategy + tests.
crates/gsqz/Cargo.toml	Bumps gobby-squeeze version to 0.4.1.
crates/ghook/src/transport.rs	Implements spool-first enqueue + POST + quarantine + atomic write helper.
crates/ghook/src/terminal_context.rs	Captures/injects terminal context for selected hooks.
crates/ghook/src/main.rs	Adds ghook CLI modes (--gobby-owned/--diagnose/--version) and orchestration.
crates/ghook/src/envelope.rs	Defines v1 inbox envelope schema + schema-validation tests.
crates/ghook/src/diagnose.rs	Implements --diagnose output + schema-validation tests.
crates/ghook/src/detach.rs	Implements detach (setsid/FreeConsole); includes Windows 2024 unsafe extern fix.
crates/ghook/src/cli_config.rs	Defines per-CLI critical/terminal-context hook registries.
crates/ghook/schemas/inbox-envelope.v1.schema.json	Adds JSON Schema for inbox envelope v1.
crates/ghook/schemas/diagnose-output.v1.schema.json	Adds JSON Schema for diagnose output v1.
crates/ghook/README.md	Adds crate README describing CLI surface and schemas.
crates/ghook/Cargo.toml	Defines gobby-hooks crate metadata/deps; bumps to 0.1.1.
crates/gcore/src/project.rs	Adds shared project-root walk-up + project-id read helpers.
crates/gcore/src/lib.rs	Exposes bootstrap, daemon_url, and project modules.
crates/gcore/src/daemon_url.rs	Adds dial-url normalization for wildcard listen hosts + tests.
crates/gcore/src/bootstrap.rs	Adds bootstrap.yaml parsing with infallible defaults + tests.
crates/gcore/Cargo.toml	Defines gobby-core crate metadata/deps.
crates/gcode/src/search/fts.rs	Adds LIKE escaping helper and adjusts symbol resolution fallback behavior.
crates/gcode/src/project.rs	Removes duplicated project helpers now provided by gobby-core.
crates/gcode/src/config.rs	Migrates project root/id resolution to gobby-core::project.
crates/gcode/src/commands/init.rs	Simplifies warning emission match arm.
crates/gcode/src/commands/index.rs	Migrates project root/id resolution to gobby-core::project.
crates/gcode/src/commands/graph.rs	Deduplicates unresolved-symbol empty response path.
crates/gcode/Cargo.toml	Adds gobby-core dependency and bumps gobby-code version to 0.6.0.
README.md	Updates workspace overview and install instructions to include ghook/gobby-core.
Cargo.toml	Adds gcore/ghook to workspace members and release opt-level override.
Cargo.lock	Updates dependency graph for new crates/versions (but currently inconsistent for gobby-hooks).
CHANGELOG.md	Adds entries for gcode 0.6.0, gsqz 0.4.1, gobby-hooks 0.1.1/0.1.0, gobby-core 0.1.0.
.github/workflows/release-ghook.yml	Adds release workflow for gobby-hooks (ghook) binaries + crates.io publish.
.github/workflows/release-gcore.yml	Adds crates.io publish workflow for gobby-core.
.github/workflows/release-gcode.yml	Gates GitHub Release on crates.io publish (needs: [build, publish]).
.github/workflows/ci.yml	Adds dedicated clippy/test steps for gobby-core and gobby-hooks.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

gobby_core::project::{find_project_root, read_project_id} was moved here and the equivalent unit tests were removed from crates/gcode/src/project.rs. To avoid a coverage regression (and to keep this shared crate safe to evolve), please add unit tests in gcore covering: finding roots via project.json and gcode.json, returning None when absent, and read_project_id preferring id with fallback to project_id.

Suggested change

	}
	}
	#[cfg(test)]
	mod tests {
	use super::{find_project_root, read_project_id};
	use std::fs;
	use std::path::{Path, PathBuf};
	use std::time::{SystemTime, UNIX_EPOCH};
	struct TestDir {
	path: PathBuf,
	}
	impl TestDir {
	fn new() -> Self {
	let unique = format!(
	"gcore-project-tests-{}-{}",
	std::process::id(),
	SystemTime::now()
	.duration_since(UNIX_EPOCH)
	.expect("system time before unix epoch")
	.as_nanos()
	);
	let path = std::env::temp_dir().join(unique);
	fs::create_dir_all(&path).expect("failed to create test directory");
	Self { path }
	}
	fn path(&self) -> &Path {
	&self.path
	}
	}
	impl Drop for TestDir {
	fn drop(&mut self) {
	let _ = fs::remove_dir_all(&self.path);
	}
	}
	#[test]
	fn find_project_root_detects_project_json() {
	let temp = TestDir::new();
	let root = temp.path().join("workspace");
	let nested = root.join("a").join("b");
	fs::create_dir_all(root.join(".gobby")).expect("failed to create .gobby");
	fs::create_dir_all(&nested).expect("failed to create nested directories");
	fs::write(root.join(".gobby").join("project.json"), r#"{"id":"proj-1"}"#)
	.expect("failed to write project.json");
	let found = find_project_root(&nested);
	assert_eq!(found, Some(root));
	}
	#[test]
	fn find_project_root_detects_gcode_json() {
	let temp = TestDir::new();
	let root = temp.path().join("workspace");
	let nested = root.join("src").join("deep");
	fs::create_dir_all(root.join(".gobby")).expect("failed to create .gobby");
	fs::create_dir_all(&nested).expect("failed to create nested directories");
	fs::write(root.join(".gobby").join("gcode.json"), r#"{"name":"proj"}"#)
	.expect("failed to write gcode.json");
	let found = find_project_root(&nested);
	assert_eq!(found, Some(root));
	}
	#[test]
	fn find_project_root_returns_none_when_absent() {
	let temp = TestDir::new();
	let start = temp.path().join("no").join("project").join("here");
	fs::create_dir_all(&start).expect("failed to create start directory");
	let found = find_project_root(&start);
	assert_eq!(found, None);
	}
	#[test]
	fn read_project_id_prefers_id_over_project_id() {
	let temp = TestDir::new();
	let root = temp.path().join("workspace");
	fs::create_dir_all(root.join(".gobby")).expect("failed to create .gobby");
	fs::write(
	root.join(".gobby").join("project.json"),
	r#"{"id":"preferred-id","project_id":"legacy-id"}"#,
	)
	.expect("failed to write project.json");
	let id = read_project_id(&root).expect("failed to read project id");
	assert_eq!(id, "preferred-id");
	}
	#[test]
	fn read_project_id_falls_back_to_project_id() {
	let temp = TestDir::new();
	let root = temp.path().join("workspace");
	fs::create_dir_all(root.join(".gobby")).expect("failed to create .gobby");
	fs::write(
	root.join(".gobby").join("project.json"),
	r#"{"project_id":"legacy-id"}"#,
	)
	.expect("failed to write project.json");
	let id = read_project_id(&root).expect("failed to read project id");
	assert_eq!(id, "legacy-id");
	}
	}

[Copilot]

PR title/description frames this as a narrow Windows hotfix for gobby-hooks, but this PR also introduces gobby-core, adds the ghook crate/workflow/docs, bumps gcode to 0.6.0, and bumps gsqz to 0.4.1. Please either update the PR description/title to reflect the broader scope or split into smaller PRs so the hotfix can ship independently.

[Copilot]

quarantine_malformed_at uses b64 in two serde_json::json! invocations, which will move the String the first time and fail to compile when reused for meta. Clone the value (or encode twice / store as &str) so both JSON objects can include the same base64 payload.

[Copilot]

atomic_write uses std::fs::rename(tmp, final_path) which will fail on Windows if final_path already exists (unlike POSIX rename-overwrite). This breaks rewriting stable paths like ~/.gobby/bin/.ghook-compatibility on subsequent runs, potentially leaving the daemon with stale compatibility info. Consider explicitly handling the destination-exists case (e.g., remove/replace semantics on Windows) for callers that overwrite a fixed filename.

[Copilot]

glob_to_like_prefix now escapes %, _, and \ with backslashes, but the SQL that consumes this value (e.g. cs.file_path LIKE ?) does not use an ESCAPE '\' clause. In SQLite, backslash is not an escape character unless ESCAPE is specified, so the escaping is currently ineffective and may produce incorrect prefilter behavior for paths containing these characters. Either add ESCAPE '\' wherever the prefix is used, or stop inserting backslashes here.