-
Notifications
You must be signed in to change notification settings - Fork 51
add a timeout to auto select method #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
thank you very much |
|
well, don't you think it's kinda pointless remembering that you just need to put very small effort to push a button ?. imo. |
The question you should make is the other way around. |
im totally agree, i have implemented automatic hen on my local machine also. as example, there's no way for us to inject external exploit (like listening port, etc). and because of that, users will need to burn new disc in order when the update released. maybe, devs will add new event button like "Press R1 to start listening port" and we can inject exploit from that port. we don't know. and i think, if you wanna make an automatic process, it's better to save as file like "autohen.txt" with name of the exploit in it like poops/lapse. when you don't need the autohen, just press and hold button like R1 when opening the bd, if so. |
|
The automatic loader still gives you option to press buttons btw. So any other shortcut might as well be implemented. Bioses, bootloaders, grub, a LOT of software works that way with a autoselection if you press nothing. Would anyone say grub or computer bioses are limited by that feature? I don't think so. |
okay, i got what you mean, sorry my bad. i forgot that you just add a timeout for automatic select. so yeah, maybe your PR will be merged. upvote. |
|
I suggest, like the initial issue to autoselect poopsploit instantly for v12.50-12.52, since it's the only available exploit there, and the timeout should only be for the lower versions. I think it makes more sense this way |
That might sound better, but as I initially thought and cleverly @dickymuliafiqri pointed out already: being able to choose what you want to do is a feature, even when for now there is only one option. |
So I guess a config file with options to select timeout time (0 sec for instantly) and default payload selection is a better alternstive, right? |
If you can include an interface to set up this configuration, yes. If the user would need to use a ps4 explorer or ftp to create that file, then no, it is worse. |
Yes specially cuz there are 2 options on the disc. Lapse and Poops but only 1 option of goldhen. Add the option to load 18.6 with Lapse. |
|
@neo305 hey my friend, adding old payloads to the disc is probably not going to get approval. If there are bugs in the latest goldhen you should report them instead of asking for old goldhen being added into the disc. For now, you can still change the payload in your hard drive using some ps4 explorer for the version you choose. Edit: and this has absolutely nothing to do with this pull request |
| console.println("Auto-selected: Lapse"); | ||
| } else { | ||
| console.println("Auto-selected: Poops"); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using this might be a little helpful
console.println("Auto-selected: " + (lapseSupported ? "Lapse" : "Poops"));There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it would become simpler, one line
Okay mate I'll use "Add a suggestion" button from now on, thank you for your effort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code quality is not measured by number of lines, there are other factors involved. But your suggestion was good.

Closes #2