feat(lifecycle-keycloak): refactor secrets generation for GitOps/ArgoCD compatibility#46
Open
feat(lifecycle-keycloak): refactor secrets generation for GitOps/ArgoCD compatibility#46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the generation of secrets within the
lifecycle-keycloakHelm chart to ensure full compatibility with GitOps tools like ArgoCD. Previously, the use ofrandAlphaNumcombined with Helm hooks (pre-install) and.Release.IsInstallconditions caused persistent issues where secrets were either pruned during synchronization or continually overwritten during eachhelm templateevaluation by ArgoCD (resulting inOutOfSyncstates).By introducing an idempotent approach (similar to Bitnami charts) via a new
lifecycle-keycloak.getValueFromSecrethelper, we now:.Release.IsInstallconstraints, ensuring the secret manifests are consistently evaluated, rendered, and maintained across regular upgrades.helm.sh/hookannotations, allowing ArgoCD to manage these secrets correctly as standard, tracked resources.Changes Made
lifecycle-keycloak.getValueFromSecrethelper in_helpers.tplto fetch existing secret values directly from the cluster state.bootstrap-admin-secret.yaml,github-idp-secret.yaml,keycloak-idp-secrets.yaml,lifecycle-ui-secret.yaml, andpostgres-secret.yamlto use the new helper and remove hooks/.Release.IsInstall.Chart.yamlandREADME.mdto0.8.0(minor bump due to significant GitOps refactoring).Verification
getValueFromSecret.