fix tests (+memfs +jest)#869
Open
maiconcarraro wants to merge 2 commits intoGoogleChromeLabs:mainfrom
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ibrahimkarahan I noticed the last checks are failing, and it could be the reason to not release a new version yet, so sending this PR to fix the tests and try to help release a new version soon - a lot of devs from PWABuilder will benefit from this.
Some tests are using
mock-fswhich has some incompatibility at the moment: tschaub/mock-fs#384 and that's the cause for these errors: https://github.com/GoogleChromeLabs/bubblewrap/actions/runs/9993866664/job/27622289533Module mocking with jasmine is a little bit tricky, but very easy with jest, so while doing the replacement of mock-fs to
memfsI also migrated tojest(and ts-jest), I know it can be controversial... I couldn't make it work well with jasmine... I did make sure to match the previous expected result, including the customization for some describe errors.Before (from CI):
After:
