fix(cli): use single quote to prevent bash expansion#982
Open
mongj wants to merge 2 commits intoGoogleChromeLabs:mainfrom
Open
fix(cli): use single quote to prevent bash expansion#982mongj wants to merge 2 commits intoGoogleChromeLabs:mainfrom
mongj wants to merge 2 commits intoGoogleChromeLabs:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #973
Problem
When signing APKs or App Bundles, the keystore password and key password are passed to command-line tools (apksigner and jarsigner). Currently, these passwords were wrapped in double quotes ("), which allows bash to perform expansion on special characters like $, !, backticks, and others.
For example, if a user's keystore password contains characters like
$ecretorpa$$word, bash would interpret$ecretor$$as variable references, causing the signing process to fail with incorrect password errors.Solution
Updated
signApk()andsignAppBundle()methods to use single quotes instead of double quotes for password parameters, so we use the password as a literal string. Also escapes single quotes in the password.Testing