Feature/catalog-Add BigQuery and BigLake hierarchy UI#356
Feature/catalog-Add BigQuery and BigLake hierarchy UI#356aditee-accenture wants to merge 18 commits intoGoogleCloudDataproc:mainfrom
Conversation
…-accenture/dataproc-jupyter-plugin-fork" This reverts commit bcea304, reversing changes made to da15ffc.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new 'Catalog' feature, providing a unified user interface for exploring and navigating data hierarchies across BigQuery and BigLake within a project. This enhancement streamlines data discovery by presenting a structured, tree-like view of datasets, tables, and columns, improving the overall user experience for interacting with various data sources. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant UI enhancement by implementing a hierarchical view for BigQuery and BigLake resources within a new 'Catalog' explorer. The changes include a major refactoring, moving BigQuery-related components into a catalog directory and splitting services for better organization. The tree navigation logic has been updated to support the new nested structure (Project -> BigQuery/BigLake -> Dataset -> Table). While the implementation correctly reflects the new hierarchy, I've identified a couple of areas for improvement. The logic for retrieving parent data in the tree is fragile and could be made more robust. Additionally, there appears to be some placeholder code for the BigLake functionality that should be addressed.
| const treeStructureforTables = () => { | ||
| let tempData = [...treeStructureData]; | ||
| const datasetName = currentNode.data.name; | ||
| const projectName = currentNode.parent?.parent?.data?.name; |
There was a problem hiding this comment.
Accessing projectName via currentNode.parent?.parent?.data?.name is fragile and tightly couples the logic to the tree's depth. To improve this, you could propagate the projectId down to child nodes.
For instance, in treeStructureforDatasets, you could add projectId: projectData.name to each dataset node. Then, this line could be simplified to const projectName = currentNode.data.projectId;.
This would make the code more maintainable and less prone to breaking from UI structure changes. The same principle applies to treeStructureforSchema where an even longer chain (.parent.parent.parent) is used.
| node.toggle(); | ||
| } else if (depth === 2 && !node.isOpen) { | ||
| if (node.data.name === 'Biglake') { | ||
| console.log('hello biglake'); |
There was a problem hiding this comment.
This console.log appears to be a placeholder for unimplemented functionality for 'Biglake' nodes. It should be replaced with the actual implementation or removed if this functionality is not yet ready.
3 participants
This PR implements the functionality to navigate data hierarchies within a project.
It handles the top-level branching into BigQuery or BigLake, followed by their deeper nested structures.