feature/ Catalog implementation - Updated folder structure and added Catalog to activity bar#357
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the data exploration capabilities by expanding the "Dataset Explorer" panel to a more comprehensive "Catalog." This change allows users to view and interact with both BigQuery and BigLake assets, moving beyond the previous BigQuery-only scope. To support this broader functionality and improved organization, the internal codebase has undergone a substantial refactoring, establishing a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a significant refactoring by renaming the 'Dataset Explorer' to 'Catalog' and restructuring the project directories accordingly. While the changes are extensive and lay the groundwork for the new Catalog feature, I've identified a few issues. There is a critical bug in src/index.ts that will prevent the new Catalog widget from refreshing correctly. Additionally, the new bigqueryWidgetService.ts contains several instances of dead code, unused variables, and typos in error messages. The new catalog.tsx component also has a console.log statement and a state variable that is not being used correctly. Addressing these points will improve the code's correctness and maintainability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ubha-accenture/dataproc-jupyter-plugin-fork into feature/catalog-new-structure
Catalog Implementation: This feature is to expand the Dataset Explorer panel's scope from displaying only native BigQuery assets to include both BigQuery and BigLake assets.
Changes included in the CL: