Skip to content

feature/ Catalog implementation - Updated folder structure and added Catalog to activity bar#357

Open
aditee-accenture wants to merge 7 commits intoGoogleCloudDataproc:mainfrom
Shubha-accenture:feature/catalog-new-structure
Open

feature/ Catalog implementation - Updated folder structure and added Catalog to activity bar#357
aditee-accenture wants to merge 7 commits intoGoogleCloudDataproc:mainfrom
Shubha-accenture:feature/catalog-new-structure

Conversation

@aditee-accenture
Copy link
Copy Markdown
Collaborator

@aditee-accenture aditee-accenture commented Mar 16, 2026

Catalog Implementation: This feature is to expand the Dataset Explorer panel's scope from displaying only native BigQuery assets to include both BigQuery and BigLake assets.

Changes included in the CL:

  1. Renamed the Dataset Explorer to Catalog in Primary Activity bar.
  2. To align with the broader scope, the internal directory structure has been refactored to reflect the new Catalog architecture. The src/bigQuery directory was migrated into a new src/catalog folder, separating the main widget into src/catalog/bigquery/ and reusable components into src/catalog/common/.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the data exploration capabilities by expanding the "Dataset Explorer" panel to a more comprehensive "Catalog." This change allows users to view and interact with both BigQuery and BigLake assets, moving beyond the previous BigQuery-only scope. To support this broader functionality and improved organization, the internal codebase has undergone a substantial refactoring, establishing a new src/catalog directory structure.

Highlights

  • Renamed Dataset Explorer to Catalog: The "Dataset Explorer" panel in the Primary Activity bar has been renamed to "Catalog" to reflect its expanded scope.
  • Refactored Directory Structure: The internal directory structure has been reorganized, migrating src/bigQuery to src/catalog, with the main widget in src/catalog/bigquery/ and reusable components in src/catalog/common/.
  • Expanded Data Asset Scope: The Catalog now supports displaying both native BigQuery and BigLake assets, broadening its data exploration capabilities.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/catalog/bigquery/bigqueryWidgetService.ts
    • Added a new service file containing static asynchronous methods for interacting with various BigQuery APIs, including previewing data, fetching schema, listing datasets and tables, retrieving dataset/table information, listing projects, and performing searches.
  • src/catalog/catalog.tsx
    • Added a new React component that implements the Catalog user interface, featuring a tree view for projects, datasets, and tables, and handling loading states and API errors.
  • src/index.ts
    • Updated imports and references to reflect the renaming of "Dataset Explorer" to "Catalog" and the new CatalogWidget.
    • Replaced datasetExplorerIcon with catalogIcon and BigQueryWidget with CatalogWidget throughout the file.
    • Adjusted theme-related icon assignments to use the new catalogIcon and catalogIconDark.
    • Modified the logging message to reflect "Catalog is enabled."
  • style/icons/catalog_icon_dark.svg
    • Added a new SVG icon for the Catalog in dark theme.
  • style/icons/catalog_icon_light.svg
    • Added a new SVG icon for the Catalog in light theme.
Activity
  • No human activity (comments, reviews, progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant refactoring by renaming the 'Dataset Explorer' to 'Catalog' and restructuring the project directories accordingly. While the changes are extensive and lay the groundwork for the new Catalog feature, I've identified a few issues. There is a critical bug in src/index.ts that will prevent the new Catalog widget from refreshing correctly. Additionally, the new bigqueryWidgetService.ts contains several instances of dead code, unused variables, and typos in error messages. The new catalog.tsx component also has a console.log statement and a state variable that is not being used correctly. Addressing these points will improve the code's correctness and maintainability.

Comment thread src/index.ts
Comment thread src/catalog/bigquery/bigqueryWidgetService.ts Outdated
Comment thread src/catalog/bigquery/bigqueryWidgetService.ts Outdated
Comment thread src/catalog/bigquery/bigqueryWidgetService.ts Outdated
Comment thread src/catalog/bigquery/bigqueryWidgetService.ts Outdated
Comment thread src/catalog/catalog.tsx Outdated
Comment thread src/catalog/catalog.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant