Skip to content

chore(secretmanager): Add Regional Code Samples for Delayed Destroy #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(secretmanager): Add Regional Code Samples for Delayed Destroy #2988

wants to merge 2 commits into from

Conversation

YashSaraf11
Copy link
Contributor

Changes

  • Added the necessary code samples for Delayed Destroy
  • Added the test files for the code samples added
  • Add the required changes in the fixture file

Prerequisite

closes: #<2987>

@YashSaraf11 YashSaraf11 requested review from a team as code owners April 11, 2025 06:54
@product-auto-label product-auto-label bot added api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples. labels Apr 11, 2025
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Apr 11, 2025 •
edited
Loading

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

amanda-tarafa
amanda-tarafa requested changes Apr 30, 2025
View reviewed changes
Copy link
Member

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change and a question. Thanks.

secretmanager/api/SecretManager.Samples/DisableRegionalSecretDelayedDestroy.cs
Comment on lines +39 to +40
// Build the parent resource name.
LocationName location = new LocationName(projectId, locationId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are not using this at all, just remove these lines.

secretmanager/api/SecretManager.Samples.Tests/DisableRegionalSecretDelayedDestroyTests.cs
projectId: secret.SecretName.ProjectId, locationId: secret.SecretName.LocationId, secretId: secret.SecretName.SecretId);

// Assert that the secret was created with the correct configurations.
Assert.Null(disabledSecret.VersionDestroyTtl);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you check here that the secret is not enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanda-tarafa amanda-tarafa amanda-tarafa requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@amanda-tarafa amanda-tarafa

@NaMNDV NaMNDV

Labels
api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YashSaraf11 @amanda-tarafa @jskeet @NaMNDV