Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a new includePath configuration to filter which storage objects trigger transcription, skipping files whose paths don’t start with the specified prefix.
- Introduce
includePathin config and extension parameters - Add runtime check in
transcribeAudioto skip non-matching paths and a correspondinglogs.pathNotMatchinghelper - Update tests, changelog, and bump extension version to cover the new behavior
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| speech-to-text/functions/src/logs.ts | Added pathNotMatching log helper |
| speech-to-text/functions/src/index.ts | Inserted include-path check in the trigger handler |
| speech-to-text/functions/src/config.ts | Exposed INCLUDE_PATH env var as config.includePath |
| speech-to-text/functions/tests/path-filter.test.ts | Added tests for include-path filtering behavior |
| speech-to-text/extension.yaml | Added INCLUDE_PATH parameter and bumped version to 0.1.7 |
| speech-to-text/CHANGELOG.md | Documented version 0.1.7 and feature addition |
Comments suppressed due to low confidence (1)
speech-to-text/functions/src/logs.ts:61
- [nitpick] Consider renaming 'pathNotMatching' to something like 'skipDueToIncludePath' or 'logPathSkip' to more clearly convey its purpose and match other log helper names.
export const pathNotMatching = (filePath: string, includePath: string) => {
| /** Check if the file path matches the include path */ | ||
| if (config.includePath && !object.name.startsWith(config.includePath)) { | ||
| // We don't want to log this, as it's a common occurence | ||
| // logs.pathNotMatching(object.name, config.includePath); |
There was a problem hiding this comment.
[nitpick] Commented-out code can be removed or replaced with a debug-level log to avoid clutter and improve readability.
26a893f to
0a2368e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #106