join_separator support for the output log line#14
join_separator support for the output log line#14bernii wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
AFAICT your concern with the long log line is addressed by the pending PR The fact that exceptions from text logs could end up on a single line was never intended. The mentioned PR makes sure that there is always a line separator in between. PTAL whether this addresses your requirements. |
|
Yeah looks like #10 already solves it! I'm going to close this one then, thanks! |
The plugin is generating a flat log line which is really hard to read as full stack trace in a single line is not really human readable.
This PR adds support for
join_separatorthat allows the user to customize the character that is used when concatenating detected stack trace lines (for examplejoin_separator "\n"can be used).