Closed
Conversation
Author
|
Do I need fixing code to pass rubocop checks? |
|
@qingling128 I recall you looked into the fluentd API migration. Is this something we want to commit? |
Contributor
|
@jkohen - Yes. We should include this in |
|
This is needed to allow implementations to use fluentd gracefulReload API endpoint. Will fix this issue #77 . Can we get some priority on getting this merged? |
This was referenced Sep 13, 2021
|
Is this going to be merge in at some point to support new gracefullReload API endpoint? |
Cryptophobia
pushed a commit
to Cryptophobia/fluent-plugin-detect-exceptions
that referenced
this pull request
Nov 10, 2021
- fixing missing code to make v1 API commit work with upstream changes - fixing functions for new parameter force_line_breaks - fixing rubocop errors and exanded lineLength to 100 chars - all tests pass on ruby 2.7.4 - this combines GoogleCloudPlatform#45 (resolves GoogleCloudPlatform#45) and reconciles it for the latest code changes in upstream Signed-off-by: Cryptophobia <aouzounov@vmware.com>
|
Please close this one as it does not conform to latest code changes since the PR is old. #93 is tested and working with latest code. I fixed rake test errors and all tests passing on ruby 2.7.4 . Going to test this out in dev, staging. |
Cryptophobia
pushed a commit
to Cryptophobia/fluent-plugin-detect-exceptions
that referenced
this pull request
Oct 19, 2023
- fixing missing code to make v1 API commit work with upstream changes - fixing functions for new parameter force_line_breaks - fixing rubocop errors and exanded lineLength to 100 chars - all tests pass on ruby 2.7.4 - this combines GoogleCloudPlatform#45 (resolves GoogleCloudPlatform#45) and reconciles it for the latest code changes in upstream Signed-off-by: Cryptophobia <aouzounov@gatech.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read "Updating Plugins Overview" before release
new version of this plugin.
See https://docs.fluentd.org/v1.0/articles/plugin-update-from-v0.12