Add support for Ruby seg fault traces#94
Open
stanhu wants to merge 4 commits intoGoogleCloudPlatform:masterfrom
Open
Add support for Ruby seg fault traces#94stanhu wants to merge 4 commits intoGoogleCloudPlatform:masterfrom
stanhu wants to merge 4 commits intoGoogleCloudPlatform:masterfrom
Conversation
Ruby seg faults contain a lot of useful information. When the lines are split across log entries, it makes debugging quite difficult.
stanhu
force-pushed
the
sh-add-ruby-segfault-handling
branch
from
bb69399 to
f7c3219
Compare
stanhu
changed the title
Author
|
@igorpeshansky Would you mind reviewing this? |
The newlines can be stripped in the Ruby exception in JSON output. Relax the regular expression to handle that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby seg faults contain a lot of useful information. When the lines
are split across log entries, it makes debugging quite difficult.