-
Notifications
You must be signed in to change notification settings - Fork 451
integrating takeover API in all bucket layers #3268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3268 +/- ##
==========================================
+ Coverage 78.51% 78.62% +0.10%
==========================================
Files 128 129 +1
Lines 17657 17831 +174
==========================================
+ Hits 13863 14019 +156
- Misses 3331 3349 +18
Partials 463 463
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
internal/storage/gcs/bucket.go
Outdated
// continuing from the offset. | ||
CreateAppendableObjectWriter(ctx context.Context, | ||
req *CreateObjectRequest, | ||
opts *storage.AppendableWriterOpts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need storage.AppendableWriterOpts as seperate argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the method definition to avoid using this argument directly.
Description
Adding CreateAppendableObjectWriter method to all bucket interfaces , to implement the takeover support for appendable unfinalized objects in ZB. Ref: link
Implementation and tests will be included in a follow-up PR.
Link to the issue in case of a bug fix.
b/415727697
Testing details
Any backward incompatible change? If so, please explain.