Skip to content

integrating takeover API in all bucket layers #3268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

anushka567
Copy link
Member

@anushka567 anushka567 commented May 6, 2025

Description

Adding CreateAppendableObjectWriter method to all bucket interfaces , to implement the takeover support for appendable unfinalized objects in ZB. Ref: link
Implementation and tests will be included in a follow-up PR.

Link to the issue in case of a bug fix.

b/415727697

Testing details

  1. Manual - Manually testing of different flows - No breakage.
  2. Unit tests - NA
  3. Integration tests - NA

Any backward incompatible change? If so, please explain.

@anushka567 anushka567 added the execute-integration-tests Run only integration tests label May 6, 2025
@kislaykishore kislaykishore requested review from a team and vipnydav and removed request for a team May 6, 2025 09:33
Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 3.33333% with 58 lines in your changes missing coverage. Please review.

Project coverage is 78.62%. Comparing base (22649eb) to head (47cd91a).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
internal/gcsx/prefix_bucket.go 0.00% 11 Missing ⚠️
internal/ratelimit/throttled_bucket.go 0.00% 9 Missing ⚠️
internal/gcsx/content_type_bucket.go 0.00% 6 Missing ⚠️
internal/storage/debug_bucket.go 0.00% 6 Missing ⚠️
internal/storage/mock/testify_mock_bucket.go 0.00% 6 Missing ⚠️
internal/storage/testify_mock_bucket.go 0.00% 6 Missing ⚠️
internal/monitor/bucket.go 0.00% 5 Missing ⚠️
internal/storage/fake/bucket.go 0.00% 3 Missing ⚠️
internal/storage/mock_bucket.go 0.00% 3 Missing ⚠️
internal/storage/caching/fast_stat_bucket.go 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3268      +/-   ##
==========================================
+ Coverage   78.51%   78.62%   +0.10%     
==========================================
  Files         128      129       +1     
  Lines       17657    17831     +174     
==========================================
+ Hits        13863    14019     +156     
- Misses       3331     3349      +18     
  Partials      463      463              
Flag Coverage Δ
unittests 78.62% <3.33%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anushka567 anushka567 marked this pull request as ready for review May 6, 2025 10:07
@anushka567 anushka567 requested a review from a team as a code owner May 6, 2025 10:07
// continuing from the offset.
CreateAppendableObjectWriter(ctx context.Context,
req *CreateObjectRequest,
opts *storage.AppendableWriterOpts,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need storage.AppendableWriterOpts as seperate argument?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the method definition to avoid using this argument directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants