chore: Migrate gsutil usage to gcloud storage #1257
Conversation
|
Hi @minherz, Can we get your review on this PR? Thanks! |
Summary of ChangesHello @bhandarivijay-png, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request initiates the migration from the legacy Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request automates the migration from gsutil to gcloud storage. While the command replacement from gsutil cp -r to gcloud storage cp --recursive is syntactically correct according to the migration guide, my review has uncovered a significant pre-existing issue in the deployment logic. The artifacts uploaded to Google Cloud Storage by this command are not actually used by the GCE instance's startup script, which instead builds the application from source. This makes the upload step redundant. I have added comments with high and medium severity to highlight this issue and suggest corrective actions.
| mvn clean package | ||
|
|
||
| gsutil cp -r target/${WAR} config/base gs://${BUCKET}/gce/ | ||
| gcloud storage cp --recursive target/${WAR} config/base gs://${BUCKET}/gce/ |
There was a problem hiding this comment.
This command uploads build artifacts to a GCS bucket, but the startup script (scripts/startup-script.sh) used for the GCE instance does not use these artifacts. Instead, it clones the source code from GitHub and builds the project from scratch on the instance. This makes the upload step unnecessary and the deployment process inefficient.
I recommend one of the following fixes:
- Remove this
gcloud storage cpcommand and relatedBUCKETlogic if building on the instance is the desired behavior. - (Preferred) Modify
scripts/startup-script.shto download the pre-built artifacts from the GCS bucket. This would significantly speed up instance startup and remove the need to installgitandmavenon the production instance.
| echo "to change them in every version of this application." | ||
| echo "" | ||
| echo "gce - mvn package; gsutil cp; gcloud compute instances create ...; - deploys to Compute Engine" | ||
| echo "gce - mvn package; gcloud storage cp; gcloud compute instances create ...; - deploys to Compute Engine" |
There was a problem hiding this comment.
This help message reflects the gcloud storage cp step. As noted in my other comment, this step appears to be redundant because the startup script does not use the uploaded artifacts. This help text should be updated to reflect the actual deployment process, which might mean removing the gcloud storage cp mention if that step is removed.
2 participants
Automated: Migrate {target_path} from gsutil to gcloud storage
This CL is part of the on going effort to migrate from the legacy
gsutiltool to the new and improvedgcloud storagecommand-line interface.gcloud storageis the recommended and modern tool for interacting with Google Cloud Storage, offering better performance, unified authentication, and a more consistent command structure with othergcloudcomponents. 🚀Automation Details
This change was generated automatically by an agent that targets users of
gsutil.The transformations applied are based on the gsutil to gcloud storage migration guide.
While we have based the automation on the migration guide, every use case is unique.
It is crucial that you thoroughly test these changes in environments appropriate to your use-case before merging.
Be aware of potential differences between
gsutilandgcloud storagethat could impact your workflows.For instance, the structure of command output may have changed, requiring updates to any scripts that parse it. Similarly, command behavior can differ subtly; the
gcloud storage rsynccommand has a different file deletion logic thangsutil rsync, which could lead to unintended file deletions.Our migration guides can help guide you through a list of mappings and some notable differences between the two tools.
Standard presubmit tests are run as part of this CL's workflow. If you need to target an additional test workflow or require assistance with testing, please let us know.
Please verify that all your Cloud Storage operations continue to work as expected to avoid any potential disruptions in production.
Support and Collaboration
The
GCS CLIteam is here to help! If you encounter any issues, have a complex use case that this automated change doesn't cover, or face any other blockers, please don't hesitate to reach out.We are happy to work with you to test and adjust these changes as needed.
Contact:
gcs-cli-hyd@google.comWe appreciate your partnership in this important migration effort!
#gsutil-migration