Set max queue count for IDPF devices; remove broken virtio logic#158
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
Set max queue count for IDPF devices; remove broken virtio logic#158copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: copybara-service[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
copybara-service
bot
force-pushed
the
test_901390740
branch
2 times, most recently
from
c24d9d7 to
c1199ec
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_901390740
branch
from
c1199ec to
56834b0
Compare
This removes the logic which claimed to enable multiqueue for virtio-net
devices, which was bugged and would never actually do anything. The
following expressions effectively mean the code was a no-op:
```sh
if [[ -n "${num_max_channels}" || "${num_max_channels}" -eq "1" ]]; then
do_nothing
...
if is_decimal_int "$num_max_channels"; then
do_nothing
...
```
The intended logic hasn't been necessary since
[this commit](https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=4490001029012539937ff02778fe6180613fa949)
(2016), which has the same effect of what this script was *trying* to
do.
For IDPF: It is possible for GCE's control plane to return more queues
than than Linux will
[use by default](https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/net/core/dev.c?h=v6.12.81#n3173).
PiperOrigin-RevId: 901390740
copybara-service
bot
force-pushed
the
test_901390740
branch
from
56834b0 to
455d350
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set max queue count for IDPF devices; remove broken virtio logic
This removes the logic which claimed to enable multiqueue for virtio-net
devices, which was bugged and would never actually do anything. The
following expressions effectively mean the code was a no-op:
The intended logic hasn't been necessary since
this commit
(2016), which has the same effect of what this script was trying to
do.
For IDPF: It is possible for GCE's control plane to return more queues
than than Linux will
use by default.