Add support for additional prompt template files #205
+23
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RRethy
force-pushed
the
Add_support_for_additional_prompt_template_files
branch
from
1692090 to
4c4efac
Compare
Mcvsguy56
approved these changes
May 10, 2025
droot
requested changes
May 12, 2025
cmd/main.go
Outdated
| @@ -257,6 +259,7 @@ func (opt *Options) bindCLIFlagsToViper(f *pflag.FlagSet) error { | |||
| f.IntVar(&opt.MaxIterations, "max-iterations", opt.MaxIterations, "maximum number of iterations agent will try before giving up") | |||
| f.StringVar(&opt.KubeConfigPath, "kubeconfig", opt.KubeConfigPath, "path to kubeconfig file") | |||
| f.StringVar(&opt.PromptTemplateFilePath, "prompt-template-file-path", opt.PromptTemplateFilePath, "path to custom prompt template file") | |||
| f.StringArrayVar(&opt.AdditionalPromptTemplateFilePaths, "additional-prompt-template-file-paths", opt.AdditionalPromptTemplateFilePaths, "additional paths to custom prompt template files") | |||
There was a problem hiding this comment.
The name is getting super verbose :) One option is to name it extra-prompt-paths (extra replaces additional pretty well)
Thinking out loud here: if the paths point to a directory, we can slurp all files from that directory (this could be added later as well doesn't have to be this PR).
PS: We will introduce short flags soon to help with the verbosity.
RRethy
force-pushed
the
Add_support_for_additional_prompt_template_files
branch
from
4c4efac to
e89890d
Compare
|
Addressed comments. However, it's no longer a feature I require so feel free to close the PR if you don't want to add this feature yet. |
Good to know. What changed ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #204
Add
--additional-prompt-template-file-pathsflag with templates that are appended to the default prompt file when generating the prompt.