Skip to content

Add google_beyondcorp_security_gateway_application as a rename. #13875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Berro321
Copy link
Contributor

@Berro321 Berro321 commented May 7, 2025

`google_beyondcorp_security_gateway_application`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 2555 insertions(+), 103 deletions(-))
google-beta provider: Diff ( 13 files changed, 2465 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 568 insertions(+))
Open in Cloud Shell: Diff ( 10 files changed, 240 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_beyondcorp_security_gateway_application (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_beyondcorp_security_gateway_application" "primary" {
  display_name = # value needed
  endpoint_matchers {
    ports = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_beyondcorp_security_gateway_application_iam_binding
    • Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
    • Fields: [application_id security_gateways_id]
  • google_beyondcorp_security_gateway_application_iam_member
    • Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
    • Fields: [application_id security_gateways_id]
  • google_beyondcorp_security_gateway_application_iam_policy
    • Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
    • Fields: [application_id security_gateways_id]

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 33
Skipped tests: 6
Affected tests: 11

Click here to see the affected service packages
  • beyondcorp
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withAndWithoutCondition
  • TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withAndWithoutCondition

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpApplication_beyondcorpApplicationBasicExample
  • TestAccBeyondcorpApplication_beyondcorpApplicationVpcExample
  • TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated
  • TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated
  • TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated
  • TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample
  • TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update
  • TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationVpcExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBeyondcorpApplication_beyondcorpApplicationBasicExample [Debug log]
TestAccBeyondcorpApplication_beyondcorpApplicationVpcExample [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationVpcExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants