Bypass inconsistent SSM repository state using a stable version suffix #2014
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @cowsking, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a modification to the E2E test framework to resolve persistent failures related to Secure Source Manager repository creation. By appending a version suffix to repository names, the system can bypass an existing inconsistent state in the test environment, ensuring that new repositories can be reliably created and managed during automated testing. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a workaround for an inconsistent state issue with SSM repositories in the E2E tests by appending a -v2 suffix to repository names. The change is straightforward and should resolve the test grid failures. My review includes a couple of suggestions to improve the code's maintainability by making the new comment more descriptive and refactoring the hardcoded version suffix into a constant.
| } | ||
| } | ||
|
|
||
| // Add suffix for fullName to fix SSM testgrid failure |
There was a problem hiding this comment.
This comment is a bit brief. To provide more context for future developers, it would be helpful to explain why the suffix is needed, summarizing the information from the PR description about the inconsistent SSM state.
| // Add suffix for fullName to fix SSM testgrid failure | |
| // Appending a version suffix to repository names to bypass an inconsistent state in SSM where some names are unusable. |
| // Add suffix for fullName to fix SSM testgrid failure | ||
| func (c *SSMClient) fullName(name string) string { | ||
| return util.SanitizeGCPRepoName(c.repoPrefix, name) | ||
| return util.SanitizeGCPRepoName(c.repoPrefix+"-v2", name) |
There was a problem hiding this comment.
The hardcoded "-v2" suffix is a 'magic string'. To improve readability and maintainability, it's best practice to define this as a package-level constant. This makes the code's intent clearer and simplifies future updates if the version needs to be incremented again (e.g., to "-v3").
You could add:
const ssmRepoVersionSuffix = "-v2"And then use it here: c.repoPrefix + ssmRepoVersionSuffix.
3 participants
This PR updates the repository name generation for Secure Source Manager (SSM) in the E2E test framework by appending a stable suffix (e.g., -v2). This change addresses an inconsistent state in the kpt-config-sync-ci-release project where specific repository names have become unusable—reporting as "already existing" during creation but "not found" during describe or delete operations.