☕ First commit TicTacToe #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu-k
suggested changes
Oct 25, 2017
stu-k
left a comment
stu-k
left a comment
There was a problem hiding this comment.
One file changed?! Tons of functions to do repetitive tasks?! This is really great work Jon! The win functions are a bit long and can be simplified, and there's one instance where a ternary would be best used, but otherwise this is good work!
| // if (checkForWin()){ | ||
| // console.log("Player" + playerTurn + " has just won the game!"); | ||
| // } | ||
| if (playerTurn === 'X') { |
There was a problem hiding this comment.
This would be a great place for a ternary!
|
|
||
| function ticTacToe(row, column) { | ||
| // Your code here | ||
| if (userInputIsValid(row, column) && isSpaceEmpty(row, column)) { |
There was a problem hiding this comment.
This is so solid, it's very readable, and it's right in your main function.
👍
| console.log('2 ' + board[2].join(' | ')); | ||
| } | ||
|
|
||
| function horizontalWin() { |
There was a problem hiding this comment.
There's a lot of repetition in these win functions. Try to simplify the logic in these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3