Tic tac react #17
Open
Tic tac react #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu-k
suggested changes
Nov 30, 2017
| } | ||
| renderSquare(i) { | ||
| return ( | ||
| <Square |
There was a problem hiding this comment.
Very nice use of a render function, but remember to code DRY (don't repeat yourself).
I'd recommend instead making this a renderSquares() function that maps through this.state.squares. This way you have access to the index of each square which you can pass into this.state.squares[index] as well as this.handleClick(index).
There was a problem hiding this comment.
Also you've got some funky indentation here. coughCOPYPASTINGFROMTHEREACTDOCScough
| } | ||
|
|
||
| handleClick(i){ | ||
|
|
| <div data-cell="0"></div> | ||
| <div data-cell="1"></div> | ||
| <div data-cell="2"></div> | ||
| {/*<div data-cell="0"></div>*/} |
| {/*<div data-cell="8"></div>*/} | ||
| {this.renderSquare(8)} | ||
| </div> | ||
|
|
|
|
||
| ReactDOM.render(<TicTacToe />, document.getElementById('tic-tac-toe')); | ||
|
|
||
| function calculateWin(squares){ |
| [0, 4, 8], | ||
| [6, 4, 2], | ||
| ]; | ||
| for(let i = 0; i <lines.length; i ++) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3