Fix: Remove aggressive sys.modules cleanup causing ComfyUI segfault

[ChrisFab16]

Fix: Remove aggressive sys.modules cleanup causing ComfyUI segfault

Issue

ComfyUI crashes with a segmentation fault during startup after loading custom nodes.

Root Cause Analysis

Comparing PR #194 changes, the diff shows the cleanup code was added:

# Added in PR #194:
modules_to_remove = []
for module in sys.modules:
    if module not in original_modules and not module.startswith("google.protobuf") and not module.startswith("onnx") and not module.startswith("cv2"):
        modules_to_remove.append(module)
for module in modules_to_remove:
    del sys.modules[module]

This cleanup removes modules from sys.modules that other custom nodes (loaded after ReActor) depend on, causing segmentation faults.

Solution

Removing this cleanup resolves the crash:

# In __init__.py, removed:
# - original_modules = sys.modules.copy()
# - The modules_to_remove loop
# Kept:
# - sys.path.remove(repo_dir)
# - sys.modules.update(original_webui_modules)

Additional Change

Unpinned versions for flexibility:

• insightface>=0.7.3
• numpy>=1.26.4

Question

The cleanup appears designed for a1111 webui compatibility. Would it make sense to add a check to only run cleanup when running in an a1111 context?

[Gourieff]

Yeah, thanks for PR my friend, I know about this issue, answered here #194 (comment)

About NSFW, if we add a possibility to disable NSFW filter, ReActor repo can be blocked again as it was in Jan 2025