fix(#3635): add in new color token for input leading icon#3697
Open
fix(#3635): add in new color token for input leading icon#3697
Conversation
Spark450
added
P3
bdfranck
reviewed
Mar 31, 2026
Collaborator
bdfranck
left a comment
bdfranck
left a comment
There was a problem hiding this comment.
Almost there! I left a couple comments.
mxsoco
force-pushed
the
mxsoco/3635-input-leading-icon-color
branch
from
7a1dd06 to
6137cbd
Compare
bdfranck
approved these changes
Mar 31, 2026
Collaborator
bdfranck
left a comment
bdfranck
left a comment
There was a problem hiding this comment.
I looked at the latest changes...
The leading and trailing icons in a v2 input are greyscale.600. ✅
The leading and trailing icons in a v1 input (with v1 tokens) are the default colour. ✅
Looks good to me! 👍
Collaborator
|
@mxsoco You can squash those two commits and this should be good to go. |
mxsoco
force-pushed
the
mxsoco/3635-input-leading-icon-color
branch
from
643d6ca to
b58e498
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before (the change)
The colour of the leading icon shared the same colour as the input text.
After (the change)
With the new token added, the leading icon is lighter than the input text.
Steps needed to test
--goa-text-input-colour-icondesign token.