fix: app header popover dropdowns missing border-radius#3700
Draft
fix: app header popover dropdowns missing border-radius#3700
Conversation
The AppHeaderMenu and AppHeader popover dropdowns had no visible
border-radius because they passed unitless values ("8", "4") to the
Popover borderradius prop. CSS border-radius requires units for non-zero
values, so these were silently discarded by the browser.
Replace with var(--goa-border-radius-xl) (0.75rem / 12px) design token
per Figma spec.
https://claude.ai/code/session_01WQuFT7xSApArMp8Y6WgssR
Spark450
added
the
P3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3659
borderradius="8"and AppHeader (tablet menu popover) passedborderradius="4"to the Popover component. These are unitless CSS values —border-radius: 8is invalid CSS (non-zero values require a unit), so the browser silently discarded the declaration, resulting in no visible border-radius.var(--goa-border-radius-xl)(0.75rem / 12px), matching the Figma design spec.var(--goa-border-radius-m)when no override is passed. Other popover consumers (Dropdown, DatePicker, MenuButton) inherit the default and are unaffected.Files changed
libs/web-components/src/components/app-header-menu/AppHeaderMenu.svelteborderradius="8"→var(--goa-border-radius-xl)for V2 navlibs/web-components/src/components/app-header/AppHeader.svelteborderradius="4"→var(--goa-border-radius-xl)for tablet menuTest plan
vitest --run --project=*-unit— 1271 passed)npm run serve:prs:react, open V2 app header with dropdown menu, confirm rounded corners on popoverhttps://claude.ai/code/session_01WQuFT7xSApArMp8Y6WgssR