Split large report pipeline into helper modules and clean exports#648
Open
WilsonkwSheng wants to merge 11 commits intomasterfrom
Open
Split large report pipeline into helper modules and clean exports#648WilsonkwSheng wants to merge 11 commits intomasterfrom
WilsonkwSheng wants to merge 11 commits intomasterfrom
Conversation
* Remove unused library inside crawlDomain * Fix eslint warnings inside crawlDomain * Resolve eslint 'customEnqueueLinksByClickingElements' was used before it was defined. * Resolve eslint warnings (shadowing, param reassign, loop await, and unused vars)
…requestHandler checks (#674) Co-authored-by: Zui Young <younglim@users.noreply.github.com>
…673) Co-authored-by: Zui Young <younglim@users.noreply.github.com>
* Cleaning up whitespaces and remove unused library * getHost imports to utils index and remove legacy exports from utils.ts * Extract getCurrentDate into utils module and export via utils/index * Extract isWhitelistedContentType and update crawlSitemap import * Extract getStoragePath/getPdfStoragePath and migrate imports to utils index
* Extract writeCsv into dedicated module and wire typed import * Extract writeSitemap into dedicated module (#650) * Extract writeSitemap into dedicated module * Extract JSON/base64 artifact pipeline into jsonArtifacts module (#651) * Extract JSON/base64 artifact pipeline into jsonArtifacts module * Extract writeScanDetailsCsv into dedicated module (#652)
This reverts commit d2a3218.
* Extract writeCsv into dedicated module and wire typed import * Extract writeSitemap into dedicated module (#650) * Extract writeSitemap into dedicated module * Extract JSON/base64 artifact pipeline into jsonArtifacts module (#651) * Extract JSON/base64 artifact pipeline into jsonArtifacts module * Extract writeScanDetailsCsv into dedicated module (#652)
…chSG/oobee into refactor-merge-axe-results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.