Make ClickableText focusable and clickable for accessibility#73
Open
PatrykMis wants to merge 6 commits intoGrapheneOS:mainfrom
Open
Make ClickableText focusable and clickable for accessibility#73PatrykMis wants to merge 6 commits intoGrapheneOS:mainfrom
PatrykMis wants to merge 6 commits intoGrapheneOS:mainfrom
Conversation
soupslurpr
suggested changes
Aug 16, 2025
app/src/main/kotlin/app/grapheneos/info/ui/reusablecomposables/ClickableText.kt
Outdated
Show resolved
Hide resolved
339b3c1 to
cead60a
Compare
Signed-off-by: Patryk Miś <foss@patrykmis.com>
Signed-off-by: Patryk Miś <foss@patrykmis.com>
Signed-off-by: Patryk Miś <foss@patrykmis.com>
Signed-off-by: Patryk Miś <foss@patrykmis.com>
Signed-off-by: Patryk Miś <foss@patrykmis.com>
cead60a to
4467559
Compare
Signed-off-by: Patryk Miś <foss@patrykmis.com>
4467559 to
7dcd698
Compare
soupslurpr
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a no-op
.clickable {}modifier to our customClickableTextimplementation.Previously, the component relied solely on
pointerInputfor tap handling, which does not expose a clickable action in the Compose semantics tree. As a result, screen readers like TalkBack often failed to recognize these elements, leading to:By adding
.clickable {}— even with an empty click handler — we ensure that:No changes to visual appearance or business logic; purely an accessibility fix + dependency updates.