Skip to content

Conversation

@coldmartian
Copy link

Enables partition alloc with advanced checks on all processes.

@thestinger
Copy link
Member

Some of this likely doesn't make sense when MTE is available and being used.

@coldmartian
Copy link
Author

coldmartian commented Nov 13, 2025

It's a good defense-in-depth measure and also useful for pixels that do not support MTE. And If I'm not mistaken, MTE only applies to main memory and not GPU memory, so this would be useful when WebGL Is enabled.

@thestinger
Copy link
Member

PartitionAlloc only manages memory where it can use MTE. What I mean is that the advanced checks don't really take MTE into account and do things differently than they should when MTE is available.

@coldmartian
Copy link
Author

coldmartian commented Nov 13, 2025

Oh. If that's the case, would it be reasonable to enable this only for Pixel devices not supporting MTE?

@thestinger
Copy link
Member

We probably need to figure out enabling a subset of the checks everywhere and a subset without MTE, not sure. We could enable it all everywhere and accept the cost of useless checks though.

@coldmartian
Copy link
Author

coldmartian commented Nov 13, 2025

The performance drop Is negligible so we could enable it everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants